Closed
Bug 1343336
Opened 7 years ago
Closed 7 years ago
Include date of commit in fdlibm README_MOZILLA
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: tjr, Assigned: tjr)
Details
(Whiteboard: [third-party-lib-audit])
Attachments
(1 file)
The Third Party Library Alert service needs the date of the commit used to be present to allow it to detect sufficiently old commits.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8842152 -
Flags: review?(bbouvier)
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8842152 [details] Bug 1343336 Include commit date in Mozilla README https://reviewboard.mozilla.org/r/116074/#review117870 ::: modules/fdlibm/update.sh:35 (Diff revision 2) > for FILE in $(ls patches/*.patch | sort); do > patch -p3 < ${FILE} > done > hg add src > > -perl -p -i -e "s/\[commit [0-9a-f]{40}\]/[commit ${COMMIT}]/" README.mozilla > +perl -p -i -e "s/\[commit [0-9a-f]{40} \(.{1,100}\)\]/[commit ${COMMIT} (${COMMITDATE})]/" README.mozilla The precise length of the datetime shouldn't even change, right? So you could even put the exact length here, instead of the {1,100} range. That being said, it doesn't matter much and it is fine as is.
Attachment #8842152 -
Flags: review?(bbouvier) → review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/3575e9555c04 Include the upstream commit date in the fdlibm Mozilla README. r=bbouvier
Keywords: checkin-needed
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3575e9555c04
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Assignee | ||
Updated•7 years ago
|
Whiteboard: [third-party-lib-audit]
You need to log in
before you can comment on or make changes to this bug.
Description
•