1343336 - Include date of commit in fdlibm README_MOZILLA

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

The Third Party Library Alert service needs the date of the commit used to be present to allow it to detect sufficiently old commits.

Comment 1

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: Bug 1343336 Include commit date in Mozilla README

Review commit: https://reviewboard.mozilla.org/r/116074/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/116074/

Comment 2

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Comment on attachment 8842152 [details]
Bug 1343336 Include commit date in Mozilla README

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/116074/diff/1-2/

Comment 3

[Benjamin Bouvier [:bbouvier] (inactive)]

Comment on attachment 8842152 [details]
Bug 1343336 Include commit date in Mozilla README

https://reviewboard.mozilla.org/r/116074/#review117870

::: modules/fdlibm/update.sh:35
(Diff revision 2)
>  for FILE in $(ls patches/*.patch | sort); do
>      patch -p3 < ${FILE}
>  done
>  hg add src
>  
> -perl -p -i -e "s/\[commit [0-9a-f]{40}\]/[commit ${COMMIT}]/" README.mozilla
> +perl -p -i -e "s/\[commit [0-9a-f]{40} \(.{1,100}\)\]/[commit ${COMMIT} (${COMMITDATE})]/" README.mozilla

The precise length of the datetime shouldn't even change, right? So you could even put the exact length here, instead of the {1,100} range. That being said, it doesn't matter much and it is fine as is.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3575e9555c04
Include the upstream commit date in the fdlibm Mozilla README. r=bbouvier

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3575e9555c04