1343407 - Video Puppeteer stall detection accesses non-existent attribute

Status: RESOLVED FIXED

(Testing Graveyard :: external-media-tests, enhancement)

Description

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

When detecting a stall video puppeteer will log information about the stalled video, however, there's a typo in the logging which attempts to access 'self._last_seen_video_state.video_uri', this should instead be 'self._last_seen_video_state.base_uri'.

Comment 1

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1343407 - Fix attribute name video_uri -> base_uri when logging stalls.

When logging a stall a non-existent attribute was attempting to be printed.
This changeset fixes the name being used so that the logging will work
correctly.

Also contains a drive by change to make _video_var_script more consistent.
There was a inconsistency with how objects were referenced which has been
removed.

Review commit: https://reviewboard.mozilla.org/r/116124/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/116124/

Comment 2

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8842250 [details]
Bug 1343407 - Fix attribute name video_uri -> base_uri when logging stalls.

https://reviewboard.mozilla.org/r/116124/#review117664

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c6a4bbb14394
Fix attribute name video_uri -> base_uri when logging stalls. r=maja_zf

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c6a4bbb14394