gmake crashes on win98 in embedding/browser/activex/src/control, when doing the export phase on a new (never built) tree [perhaps also with a clobber build too]. The crash occurs when trying to do "./mkctldef.bat L_mozctl.def" (snippet of messages below): ... ... gmake: Entering directory `/cygdrive/e/builds/tinderbox/WIN98_4.10_Depend/mozilla/embedding/browser/active x/src' gmake: Entering directory `/cygdrive/e/builds/tinderbox/WIN98_4.10_Depend/mozilla/embedding/browser/active x/src/control' Creating .deps perl -I../../../../../config ../../../../../config/build-list.pl ../../../../../config/final-link-libs mozctl ./mkctldef.bat L_mozctl.def ---crash--- A subsequent attempt of 'make export' succeeds. There are really two issues: 1) it will crash executing that batch file, unless L_mozctl.def already exists (which is why it doesn't crash on the second pass; that file does get created just before (or during) the crash. 2) in either case, though, the entire contents L_mozctl.def is "OFF\r\n", so (I guess) the activex control build is broken on win98. I experimented with 'touch'-ing that file (from the makefile) but I still crashed, so that doesn't seem to be a way to "fix" this. I don't particularly care much about point (2) as long as it is clear to external developers that building the activex control requires NT. But, it would be nice if we didn't crash on a clean build. (And, at minimum, this bug documents this crash for anyone other masochist who attempts to build on win98 :-).
hmmm I thought I can build the activeX component under win98, but I feel the danger when that gmake massacre will start.
I don't know a reason, other than this one, that would prevent the activex control from building. So, the workaround (pending evidence of other problems) could be to manually perform the steps done by mkctldef.bat (i.e., write out the .def file) and then make mkctldef.bat into an empty file (so it neither crashes nor overwrites the L_mozctl.def file). [At least I think that would be ok as a workaround].
works for me (doesn't have that crash). [Micro-nit: "...autogenerated by mkctldef.bat" -> "autogenerated by mkctldef.sh"].
Comment on attachment 77175 [details] [diff] [review] Use a shell script instead of a batch file a=asa (on behalf of drivers) for checkin to the 1.0 trunk
Created attachment 77554 [details] [diff] [review] Updated to fix micro-nit & change DEFFILE dependency from .bat -> .sh
Comment on attachment 77554 [details] [diff] [review] Updated to fix micro-nit & change DEFFILE dependency from .bat -> .sh Moving over review & approval.
adt1.0.0+ (on ADT's behalf) for approval for checkin.
Patch checked in.