gmake win98 build crashes gmake in embedding\browser\activex\src\control

RESOLVED FIXED in mozilla1.0

Status

SeaMonkey
Build Config
P3
normal
RESOLVED FIXED
16 years ago
13 years ago

People

(Reporter: John Morrison, Assigned: hacker formerly known as seawood@netscape.com)

Tracking

Trunk
mozilla1.0
x86
Windows 98

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [adt1])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

16 years ago
gmake crashes on win98 in embedding/browser/activex/src/control, when doing
the export phase on a new (never built) tree [perhaps also with a clobber
build too]. The crash occurs when trying to do "./mkctldef.bat L_mozctl.def"
(snippet of messages below):

...
...
gmake[6]: Entering directory 
`/cygdrive/e/builds/tinderbox/WIN98_4.10_Depend/mozilla/embedding/browser/active
x/src'
gmake[7]: Entering directory 
`/cygdrive/e/builds/tinderbox/WIN98_4.10_Depend/mozilla/embedding/browser/active
x/src/control'
Creating .deps
perl -I../../../../../config ../../../../../config/build-list.pl 
../../../../../config/final-link-libs mozctl
./mkctldef.bat L_mozctl.def
---crash---


A subsequent attempt of 'make export' succeeds. There are really two issues:

1) it will crash executing that batch file, unless L_mozctl.def already exists
   (which is why it doesn't crash on the second pass; that file does get
   created just before (or during) the crash.

2) in either case, though, the entire contents L_mozctl.def is "OFF\r\n", so
   (I guess) the activex control build is broken on win98.

I experimented with 'touch'-ing that file (from the makefile) but I still
crashed, so that doesn't seem to be a way to "fix" this.

I don't particularly care much about point (2) as long as it is clear to
external developers that building the activex control requires NT.

But, it would be nice if we didn't crash on a clean build. (And, at minimum,
this bug documents this crash for anyone other masochist who attempts to build
on win98 :-).

Comment 1

16 years ago
hmmm I thought I can build the activeX component under win98, but I feel the
danger when that gmake massacre will start. 
(Reporter)

Comment 2

16 years ago
I don't know a reason, other than this one, that would prevent the activex 
control from building. So, the workaround (pending evidence of other problems)
could be to manually perform the steps done by mkctldef.bat (i.e., write out
the .def file) and then make mkctldef.bat into an empty file (so it neither 
crashes nor overwrites the L_mozctl.def file). [At least I think that would 
be ok as a workaround].
Created attachment 77175 [details] [diff] [review]
Use a shell script instead of a batch file
(Reporter)

Comment 4

16 years ago
works for me (doesn't have that crash). [Micro-nit: "...autogenerated by 
mkctldef.bat" -> "autogenerated by mkctldef.sh"].
Keywords: adt1.0.0, mozilla1.0
Priority: -- → P3
Target Milestone: --- → mozilla1.0

Comment 5

16 years ago
Comment on attachment 77175 [details] [diff] [review]
Use a shell script instead of a batch file

a=asa (on behalf of drivers) for checkin to the 1.0 trunk
Attachment #77175 - Flags: approval+
Created attachment 77554 [details] [diff] [review]
Updated to fix micro-nit & change DEFFILE dependency from .bat -> .sh
Attachment #77175 - Attachment is obsolete: true
Comment on attachment 77554 [details] [diff] [review]
Updated to fix micro-nit & change DEFFILE dependency from .bat -> .sh

Moving over review & approval.
Attachment #77554 - Flags: review+
Attachment #77554 - Flags: approval+

Comment 8

16 years ago
adt1.0.0+ (on ADT's behalf) for approval for checkin.
Keywords: adt1.0.0 → adt1.0.0+
Whiteboard: [adt1]
Patch checked in.
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.