1343455 - In Rules Inspector, when using "filter styles", any clicks on any checkboxes will reopen shorthands that you've collapsed

Status: NEW

(DevTools :: Inspector: Rules, defect, P3)

Description

[Daniel Holbert [:dholbert]]

Attachment: testcase 1

STR:
 1. Load attached testcase.
 2. Right click the text and choose "Inspect Element". Go to the inspector's Rules tab if you're not already there.
 3. Type "t" into the "Filter Styles" textbox.
  --> The border, margin, and padding shorthands are toggled open.
 4. Click the triangles to close border, margin, and/or padding.
 5. Click the checkbox next to some declaration (e.g. the "width" or "left" properties)

ACTUAL RESULTS:
The shorthands that expanded in step 3 (border, margin, padding) suddenly expand again!

EXPECTED RESULTS:
The shorthands should stay collapsed, like I left them.


It looks like we're re-running the "filter" operation and greedily expanding shorthands whose subproperties match the filter but whose shorthand property does not match the filter.  This makes sense when I type in the filter textbox, but it does *not* make sense that this happens again when I simply tick/untick checkboxes.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: screencast of bug

Here's a screencast of me performing the STR. The bug happens at around 6 seconds (when I click a checkbox).

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: Bug 1343455 - Toggling checkbox for CSS rule in editor shouldn't expand collapsed computed rules.

Review commit: https://reviewboard.mozilla.org/r/116286/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/116286/

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8842433 [details]
Bug 1343455 - Toggling checkbox for CSS rule in editor shouldn't expand collapsed computed rules.

https://reviewboard.mozilla.org/r/116286/#review117966

So, this isn't fully correct. We still want to greedily expand the computed properties if the property rule is not highlighted. We need a "user-close" state when we are filtering and closing the expanded computed property.

Comment 4

[Patrick Brosset <:pbro>]

Inspector bug triage (filter on CLIMBING SHOES).