Closed Bug 1343493 Opened 3 years ago Closed 3 years ago

Update to tzdata2017a

Categories

(Core :: JavaScript: Internationalization API, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox52 --- wontfix
firefox-esr52 --- fixed
firefox53 --- fixed
firefox54 --- fixed

People

(Reporter: anba, Assigned: anba)

References

()

Details

Attachments

(1 file)

Update the tzdata info for ICU to tzdata2017a.
Attached patch bug1343493.patchSplinter Review
Generated with:
  cd intl
  ./update-tzdata.sh -e $ICU58_BUILD_DIR/bin/icupkg 2017a
  cd ../js/src/builtin
  ./make_intl_data.py tzdata


tzdata2017a adds a new time zone (America/Punta_Arenas), which is now supported in Intl.DateTimeFormat:
---
js> Intl.DateTimeFormat(undefined, {timeZone: "America/Punta_Arenas"}).resolvedOptions().timeZone
"America/Punta_Arenas"
---
Attachment #8842807 - Flags: review?(jwalden+bmo)
Attachment #8842807 - Flags: review?(jwalden+bmo) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8e2b1fec1fd7
Update tzdata in ICU data files to 2017a. r=Waldo
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8e2b1fec1fd7
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Comment on attachment 8842807 [details] [diff] [review]
bug1343493.patch

Approval Request Comment
[Feature/Bug causing the regression]:
N/A

[User impact if declined]:
Wrong or inconsistent time zone data when calling methods from Intl.DateTimeFormat or methods internally using Intl.DateTimeFormat (that means Date.prototype.toLocale(Date|Time)String()). Inconsistencies are possible when the OS already uses the current tzdata release (tzdata 2017a), but our internal ICU version still uses tzdata 2016j. 
Based on the release notes for tzdata 2017a (http://mm.icann.org/pipermail/tz-announce/2017-February/000045.html), the update is of special interest for Mongolian users (Mongolia stops observing DST) and users in Chile's Region of Magallanes (new time zone for this region).

[Is this code covered by automated tests?]:
Yes.

[Has the fix been verified in Nightly?]:
Yes.

[Needs manual test from QE? If yes, steps to reproduce]: 
No.

[List of other uplifts needed for the feature/fix]:
None.

[Is the change risky?]:
No.

[Why is the change risky/not risky?]:
It only updates time zone data files.

[String changes made/needed]:
None.
Attachment #8842807 - Flags: approval-mozilla-beta?
Comment on attachment 8842807 [details] [diff] [review]
bug1343493.patch

Update for time zone changes, ok for uplift to beta.
Attachment #8842807 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Setting qe-verify- based on André's assessment on manual testing needs (see Comment 5) and the fact that this fix has automated coverage.
Flags: qe-verify-
Being 52 an ESR version, shouldn't it be updated too?  I am not refering to a 52.0.1, but to the ESR 52.1...
(In reply to Alexandre Folle de Menezes from comment #9)
> Being 52 an ESR version, shouldn't it be updated too?  I am not refering to
> a 52.0.1, but to the ESR 52.1...

Yes, we should try to update the ESR version.
Comment on attachment 8842807 [details] [diff] [review]
bug1343493.patch

[Approval Request Comment]
User impact if declined: See comment #5.
Fix Landed on Version: mozilla53/54.
Risk to taking this patch (and alternatives if risky): See comment #5.
String or UUID changes made by this patch: None.
Attachment #8842807 - Flags: approval-mozilla-esr52?
Comment on attachment 8842807 [details] [diff] [review]
bug1343493.patch

update tzdata to 2017a
Attachment #8842807 - Flags: approval-mozilla-esr52? → approval-mozilla-esr52+
You need to log in before you can comment on or make changes to this bug.