Make use of annotations.RootedPointers and JS_HAZ_ROOTED

RESOLVED FIXED in Firefox 62

Status

()

enhancement
P3
normal
RESOLVED FIXED
3 years ago
Last year

People

(Reporter: sfink, Assigned: sfink)

Tracking

(Blocks 1 bug, {triage-deferred})

unspecified
mozilla62
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox62 fixed)

Details

Attachments

(1 attachment)

mccr8 correctly pointed out that annotations.RootedPointers is never used. Which means that JS_HAZ_ROOTED does nothing.

isRootedTypeName really ought to consult that variable instead of just using weird hardcoded parsing. (Actually, it should probably check the variable first, then use weird hardcoded parsing for whatever is inconvenient to annotate in the source.)
Keywords: triage-deferred
Priority: -- → P3
I guess so. And https://treeherder.mozilla.org/#/jobs?repo=try&revision=5bde6d7478a28415eb743cc8d8c098a5ca8123b7 seems to say we can get rid of just about all of those out-of-source special cases now. (The TokenStream thing is different, sadly.)
Assignee: nobody → sphink
Status: NEW → ASSIGNED
Comment on attachment 8984620 [details] [diff] [review]
Use JS_HAZ_ROOTED everywhere instead of programmatic annotations

Review of attachment 8984620 [details] [diff] [review]:
-----------------------------------------------------------------

As far as I can tell thie makes sense.

Thanks, I also agree using JS_HAZ_ROOTED is better.
Attachment #8984620 - Flags: review?(pbone) → review+
Pushed by sfink@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b15524c982e9
Use JS_HAZ_ROOTED everywhere instead of programmatic annotations, r=pbone
https://hg.mozilla.org/mozilla-central/rev/b15524c982e9
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.