Closed
Bug 1343686
Opened 7 years ago
Closed 7 years ago
Add a log statement to warn about dev root cert
Categories
(Toolkit :: Add-ons Manager, enhancement)
Toolkit
Add-ons Manager
Tracking
()
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: andy+bugzilla, Assigned: andy+bugzilla)
Details
Attachments
(1 file)
Suppose you followed an instruction to set xpinstall.signatures.dev-root to true. Then forgotten about it and 6 hours later tested something on production, like something on testpilot. And pressed "install" and it fails and you get something in your browser console that says: 1488406177650 addons.xpi WARN Add-on @testpilot-containers is not correctly signed Your first response might be oh noes, something is wrong with testpilot or the world. Oh noes. Really its because you set that pref. It would be nice if we could log something along the lines of: WARN Add-on @testpilot-containers is not correctly signed. WARN Preference xpinstall.signatures.dev-root is set to true. And then everyone will be able to spot quickly where the problem is.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → amckay
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8842667 [details] bug 1343686 log a message if xpinstall.signatures.dev-root is set and install fails https://reviewboard.mozilla.org/r/116430/#review118088 I might write this as: ``` let msg = `Addon ${aAddon.id} is not correctly signed.`; if (DEV_ROOT) { msg += ` (note that the DEV_ROOT pref is set)`; } logger.warn(msg); ``` but this is fine too if you just want to be done with it.
Attachment #8842667 -
Flags: review?(aswan) → review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d4ce6c0007c2 log a message if xpinstall.signatures.dev-root is set and install fails r=aswan
Keywords: checkin-needed
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d4ce6c0007c2
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•