Closed Bug 1343718 Opened 3 years ago Closed 3 years ago

Miscellaneous tidying of artifacts download code

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(3 files)

No description provided.
Depends on: 1341215
Summary: Miscellaneous tidying of artifacts download code13 → Miscellaneous tidying of artifacts download code
I now realize that the last patch doesn't really do what I wanted it to do, but all things considered, it's not entirely bad, so I'll just leave it that way, unless told otherwise. (it makes the size and file limits apply to the files that were downloaded previously, which means in practice the size limit ends up being the hard limit (1GB) + the size of all the downloads from the current session)
I also now realize that I broke some of the mach artifact subcommands, namely: clear-cache, last and print-cache. The latter two would need the pickle data to be kept... OTOH the "last" command was already broken: bug 1341205.

Is it worth keeping those two commands working? (I can see an interest in clear-cache)
Comment on attachment 8857361 [details]
Bug 1343718 - Avoid requiring an objdir when simply importing mozbuild.artifacts.

https://reviewboard.mozilla.org/r/129344/#review132272
Attachment #8857361 - Flags: review?(cmanchester) → review+
Comment on attachment 8857362 [details]
Bug 1343718 - Don't display download progress when we don't know the download size in advance.

https://reviewboard.mozilla.org/r/129346/#review132274
Attachment #8857362 - Flags: review?(cmanchester) → review+
Depends on: 1356064
For the record, I'm about to attach a new version of the third patch, which is going to, in fact, address comment 4, even though I said I wouldn't do that.
Filed bug 1356101 for the more general issue of the lack of sync between build/virtualenv_packages.txt and build/mach_bootstrap.py
Err, the unit test fails randomly on automation.
Depends on: 1356101
Comment on attachment 8857363 [details]
Bug 1343718 - Limit artifact downloads by size rather than by number.

https://reviewboard.mozilla.org/r/129348/#review132668
Attachment #8857363 - Flags: review?(cmanchester) → review+
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/56cb728c5f74
Avoid requiring an objdir when simply importing mozbuild.artifacts. r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/b5a3e4cb5090
Don't display download progress when we don't know the download size in advance. r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/3717bedc62f9
Limit artifact downloads by size rather than by number. r=chmanchester
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.