Miscellaneous tidying of artifacts download code

RESOLVED FIXED in Firefox 55

Status

()

Core
Build Config
RESOLVED FIXED
9 months ago
7 months ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

(Blocks: 1 bug)

unspecified
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

Comment hidden (empty)
(Assignee)

Updated

9 months ago
Depends on: 1341215
(Assignee)

Updated

9 months ago
Summary: Miscellaneous tidying of artifacts download code13 → Miscellaneous tidying of artifacts download code
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

7 months ago
Blocks: 1355731
(Assignee)

Comment 4

7 months ago
I now realize that the last patch doesn't really do what I wanted it to do, but all things considered, it's not entirely bad, so I'll just leave it that way, unless told otherwise. (it makes the size and file limits apply to the files that were downloaded previously, which means in practice the size limit ends up being the hard limit (1GB) + the size of all the downloads from the current session)
(Assignee)

Comment 5

7 months ago
I also now realize that I broke some of the mach artifact subcommands, namely: clear-cache, last and print-cache. The latter two would need the pickle data to be kept... OTOH the "last" command was already broken: bug 1341205.

Is it worth keeping those two commands working? (I can see an interest in clear-cache)

Comment 6

7 months ago
mozreview-review
Comment on attachment 8857361 [details]
Bug 1343718 - Avoid requiring an objdir when simply importing mozbuild.artifacts.

https://reviewboard.mozilla.org/r/129344/#review132272
Attachment #8857361 - Flags: review?(cmanchester) → review+

Comment 7

7 months ago
mozreview-review
Comment on attachment 8857362 [details]
Bug 1343718 - Don't display download progress when we don't know the download size in advance.

https://reviewboard.mozilla.org/r/129346/#review132274
Attachment #8857362 - Flags: review?(cmanchester) → review+
(Assignee)

Updated

7 months ago
Depends on: 1356064
(Assignee)

Comment 8

7 months ago
For the record, I'm about to attach a new version of the third patch, which is going to, in fact, address comment 4, even though I said I wouldn't do that.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Comment 12

7 months ago
Filed bug 1356101 for the more general issue of the lack of sync between build/virtualenv_packages.txt and build/mach_bootstrap.py
(Assignee)

Comment 13

7 months ago
Err, the unit test fails randomly on automation.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

7 months ago
Depends on: 1356101
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 20

7 months ago
mozreview-review
Comment on attachment 8857363 [details]
Bug 1343718 - Limit artifact downloads by size rather than by number.

https://reviewboard.mozilla.org/r/129348/#review132668
Attachment #8857363 - Flags: review?(cmanchester) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 24

7 months ago
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/56cb728c5f74
Avoid requiring an objdir when simply importing mozbuild.artifacts. r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/b5a3e4cb5090
Don't display download progress when we don't know the download size in advance. r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/3717bedc62f9
Limit artifact downloads by size rather than by number. r=chmanchester

Comment 25

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/56cb728c5f74
https://hg.mozilla.org/mozilla-central/rev/b5a3e4cb5090
https://hg.mozilla.org/mozilla-central/rev/3717bedc62f9
Status: NEW → RESOLVED
Last Resolved: 7 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.