1343750 - Label runnables in FTP code

Status: RESOLVED FIXED

(Core Graveyard :: Networking: FTP, enhancement, P2)

Description

[Kershaw Chang [:kershaw]]

It seems there is only one runnable need to be labeled.

http://searchfox.org/mozilla-central/rev/31b6089ce26fa76459642765115605d50a6c67b4/netwerk/protocol/ftp/FTPChannelChild.cpp#612

Comment 1

[Kershaw Chang [:kershaw]]

Attachment: Part1: Add an API to get Dispatcher from nsILoadInfo

Summary:
 - Add a new API in nsContentUtils for getting a dispatcher from nsILoadInfo
 - Note this API can be used by HttpChannelChild and FTPChannelChild

Hi Honza,
Please take a look at this patch. Thanks.

Comment 2

[Kershaw Chang [:kershaw]]

Attachment: Part2: Label runnable and IPC actor in FTP

Summary:
 - Label IPC actor before sending constructor message
 - Label FTP alart event

Comment 3

[Honza Bambas (:mayhemer)]

Comment on attachment 8846531 [details] [diff] [review]
Part1: Add an API to get Dispatcher from nsILoadInfo

Review of attachment 8846531 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsContentUtils.cpp
@@ +9995,5 @@
> +
> +    dispatcher = window->TabGroup();
> +  }
> +
> +  return dispatcher.forget();

I'm not the right review for this, but seems OK to me.

::: netwerk/protocol/http/HttpChannelChild.cpp
@@ +2077,5 @@
> +      // We have a TabGroup. This must be a top-level load.
> +      bool isMainDocumentChannel;
> +      GetIsMainDocumentChannel(&isMainDocumentChannel);
> +      MOZ_ASSERT(isMainDocumentChannel);
> +    }

fix indention

Comment 4

[Honza Bambas (:mayhemer)]

Push to try before landing, please!

Comment 5

[Kershaw Chang [:kershaw]]

(In reply to Honza Bambas (:mayhemer) from comment #4)
> Push to try before landing, please!

Thanks for the review.


https://treeherder.mozilla.org/#/jobs?repo=try&revision=f835994dad67a9c493a68d0ee8cd24d50e24d4a1&selectedJob=85879137

Comment 6

[Kershaw Chang [:kershaw]]

Attachment: Part1: Add an API to get Dispatcher from nsILoadInfo, r=mayhemer

Rebase and carry reviewer's name.

Comment 7

[Kershaw Chang [:kershaw]]

Attachment: Part2: Label runnable and IPC actor in FTP code, r=mayhemer

Carry reviewer's name.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3c56f8e6575e
Part1: Add an API to get Dispatcher from nsILoadInfo, r=mayhemer
https://hg.mozilla.org/integration/mozilla-inbound/rev/9dda60f84c84
Part2: Label runnable and IPC actor in FTPChannelChild, r=mayhemer

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3c56f8e6575e
https://hg.mozilla.org/mozilla-central/rev/9dda60f84c84