Closed Bug 1343750 Opened 3 years ago Closed 3 years ago

Label runnables in FTP code

Categories

(Core :: Networking: FTP, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: kershaw, Assigned: kershaw)

References

(Blocks 1 open bug)

Details

(Whiteboard: [necko-active][QDL][TDC-MVP][NECKO])

Attachments

(2 files, 2 obsolete files)

Summary:
 - Add a new API in nsContentUtils for getting a dispatcher from nsILoadInfo
 - Note this API can be used by HttpChannelChild and FTPChannelChild

Hi Honza,
Please take a look at this patch. Thanks.
Assignee: nobody → kechang
Attachment #8846531 - Flags: review?(honzab.moz)
Summary:
 - Label IPC actor before sending constructor message
 - Label FTP alart event
Attachment #8846532 - Flags: review?(honzab.moz)
Whiteboard: [necko-next] → [necko-active]
Comment on attachment 8846531 [details] [diff] [review]
Part1: Add an API to get Dispatcher from nsILoadInfo

Review of attachment 8846531 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsContentUtils.cpp
@@ +9995,5 @@
> +
> +    dispatcher = window->TabGroup();
> +  }
> +
> +  return dispatcher.forget();

I'm not the right review for this, but seems OK to me.

::: netwerk/protocol/http/HttpChannelChild.cpp
@@ +2077,5 @@
> +      // We have a TabGroup. This must be a top-level load.
> +      bool isMainDocumentChannel;
> +      GetIsMainDocumentChannel(&isMainDocumentChannel);
> +      MOZ_ASSERT(isMainDocumentChannel);
> +    }

fix indention
Attachment #8846531 - Flags: review?(honzab.moz) → review+
Attachment #8846532 - Flags: review?(honzab.moz) → review+
Push to try before landing, please!
(In reply to Honza Bambas (:mayhemer) from comment #4)
> Push to try before landing, please!

Thanks for the review.


https://treeherder.mozilla.org/#/jobs?repo=try&revision=f835994dad67a9c493a68d0ee8cd24d50e24d4a1&selectedJob=85879137
Rebase and carry reviewer's name.
Attachment #8846531 - Attachment is obsolete: true
Attachment #8846532 - Attachment is obsolete: true
Attachment #8850854 - Flags: review+
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3c56f8e6575e
Part1: Add an API to get Dispatcher from nsILoadInfo, r=mayhemer
https://hg.mozilla.org/integration/mozilla-inbound/rev/9dda60f84c84
Part2: Label runnable and IPC actor in FTPChannelChild, r=mayhemer
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/3c56f8e6575e
https://hg.mozilla.org/mozilla-central/rev/9dda60f84c84
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Whiteboard: [necko-active] → [necko-active][QDL][TDC-MVP][NECKO]
Priority: -- → P2
You need to log in before you can comment on or make changes to this bug.