Closed Bug 1343761 Opened 3 years ago Closed 3 years ago

Label runnables in DNS code

Categories

(Core :: Networking: DNS, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: kershaw, Assigned: kershaw)

References

(Blocks 1 open bug)

Details

(Whiteboard: [necko-active][QDL][TDC-MVP][NECKO])

Attachments

(1 file, 1 obsolete file)

We have some runnables need to be taken care of.
 - netwerk/dns/DNSListenerProxy.cpp
 - netwerk/dns/DNSRequestChild.cpp
Summary:
 - Use SystemGroup's event target for DNSRequestChild
 - Label runnables in DNSRequestChild


Honza,
Please take a look at this patch. Thanks.
Assignee: nobody → kechang
Attachment #8847881 - Flags: review?(honzab.moz)
Whiteboard: [necko-next] → [necko-active]
Comment on attachment 8847881 [details] [diff] [review]
Use SystemGroup to dispatch runnables

Review of attachment 8847881 [details] [diff] [review]:
-----------------------------------------------------------------

I'm probably not the right reviewer for this.  DNS has been long ago away from my radar.  It looks, hopefully if anything is wrong we catch it via tests.

PUSH TO TRY!
Attachment #8847881 - Flags: review?(honzab.moz) → review+
(In reply to Honza Bambas (:mayhemer) from comment #2)
> Comment on attachment 8847881 [details] [diff] [review]
> Use SystemGroup to dispatch runnables
> 
> Review of attachment 8847881 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I'm probably not the right reviewer for this.  DNS has been long ago away
> from my radar.  It looks, hopefully if anything is wrong we catch it via
> tests.
> 
> PUSH TO TRY!

Thanks.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=264ce9d552d2a2ab7f7c0b30fac91ef4d944d147
Carry reviewer's name.
Attachment #8847881 - Attachment is obsolete: true
Attachment #8850856 - Flags: review+
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3405c39b18ac
Use SystemGroup to dispatch runnables in DNSRequestChild, r=mayhemer
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/3405c39b18ac
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Whiteboard: [necko-active] → [necko-active][QDL][TDC-MVP][NECKO]
Priority: -- → P2
You need to log in before you can comment on or make changes to this bug.