Closed
Bug 1343770
Opened 7 years ago
Closed 7 years ago
Separate out Parent commands from Child commands
Categories
(Core :: Graphics: WebRender, enhancement)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: jrmuizel, Assigned: jrmuizel)
References
Details
Attachments
(1 file, 1 obsolete file)
38.14 KB,
patch
|
kats
:
review+
|
Details | Diff | Splinter Review |
This makes it so we don't send the child side commands to the parent.
Assignee | ||
Updated•7 years ago
|
Attachment #8842729 -
Attachment is patch: true
Attachment #8842729 -
Flags: review?(bugmail)
Comment 1•7 years ago
|
||
A+ patch
Assignee | ||
Comment 2•7 years ago
|
||
Attachment #8842729 -
Attachment is obsolete: true
Attachment #8842729 -
Flags: review?(bugmail)
Attachment #8842733 -
Flags: review?(bugmail)
Assignee | ||
Comment 3•7 years ago
|
||
This basically just splits the enum in two and does the necessary plumbing. The worst part is that now DisplayItemLayers need to have two arrays of commands. Fortunately, this will be going away in the future.
Updated•7 years ago
|
Assignee: nobody → jmuizelaar
Comment 4•7 years ago
|
||
Comment on attachment 8842733 [details] [diff] [review] Separate out Parent commands from Child commands Review of attachment 8842733 [details] [diff] [review]: ----------------------------------------------------------------- Nice! Moar strong typing is the better ::: gfx/layers/wr/WebRenderBridgeChild.cpp @@ +386,1 @@ > OpUseTexture(textures))); nit: overhang indent
Attachment #8842733 -
Flags: review?(bugmail) → review+
Pushed by jmuizelaar@mozilla.com: https://hg.mozilla.org/projects/graphics/rev/d6998fb6d473 Separate out Parent commands from Child commands. r=kats
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Comment 6•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d6998fb6d473
status-firefox54:
--- → fixed
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•