Closed Bug 1343770 Opened 3 years ago Closed 3 years ago

Separate out Parent commands from Child commands

Categories

(Core :: Graphics: WebRender, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: jrmuizel, Assigned: jrmuizel)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
This makes it so we don't send the child side commands to the parent.
Attachment #8842729 - Attachment is patch: true
Attachment #8842729 - Flags: review?(bugmail)
Depends on: 1341064
A+ patch
Attachment #8842729 - Attachment is obsolete: true
Attachment #8842729 - Flags: review?(bugmail)
Attachment #8842733 - Flags: review?(bugmail)
This basically just splits the enum in two and does the necessary plumbing. The worst part is that now DisplayItemLayers need to have two arrays of commands. Fortunately, this will be going away in the future.
Assignee: nobody → jmuizelaar
Comment on attachment 8842733 [details] [diff] [review]
Separate out Parent commands from Child commands

Review of attachment 8842733 [details] [diff] [review]:
-----------------------------------------------------------------

Nice! Moar strong typing is the better

::: gfx/layers/wr/WebRenderBridgeChild.cpp
@@ +386,1 @@
>                                              OpUseTexture(textures)));

nit: overhang indent
Attachment #8842733 - Flags: review?(bugmail) → review+
Pushed by jmuizelaar@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/d6998fb6d473
Separate out Parent commands from Child commands. r=kats
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.