1343799 - Label runnables in dom/media/TextTrackList.cpp

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Comment 1

[Benjamin Chen [:bechen]]

Attachment: Bug 1343799 - lable runnables in texttracklist.cpp.

Review commit: https://reviewboard.mozilla.org/r/121854/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/121854/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8848999 [details]
Bug 1343799 - lable runnables in texttracklist.cpp.

https://reviewboard.mozilla.org/r/121854/#review123808

Comment 3

[Benjamin Chen [:bechen]]

Comment on attachment 8848999 [details]
Bug 1343799 - lable runnables in texttracklist.cpp.

https://reviewboard.mozilla.org/r/121854/#review124322

::: dom/media/TextTrackList.cpp:191
(Diff revision 1)
>      event->InitEvent(NS_LITERAL_STRING("change"), false, false);
>      event->SetTrusted(true);
>  
>      nsCOMPtr<nsIRunnable> eventRunner = new ChangeEventRunner(this, event);
> -    NS_DispatchToMainThread(eventRunner);
> +    nsGlobalWindow::Cast(win)->Dispatch(
> +      "TextTrack::DispatchAsyncTrustedEvent", TaskCategory::Other,

nit, should be "TextTrackList::CreateAndDispatchChangeEvent"

Comment 4

[Benjamin Chen [:bechen]]

Comment on attachment 8848999 [details]
Bug 1343799 - lable runnables in texttracklist.cpp.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/121854/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9334df148915
lable runnables in texttracklist.cpp. r=jwwang

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9334df148915