|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
59 bytes, text/x-review-board-request
|Details | Review|
chrome://global/content/findUtils.js is reported as unreferenced by my test in bug 1316187. I can't find any use of it in our tree, and dxr doesn't seem to show current usage of it in add-ons. SeaMonkey uses its own fork of this file. I think we can just remove it.
I believe finddialog.xul, finddialog.dtd, finddialog.properties can be removed as well. Although finddialog.xul (and hence the .dtd and .properties) is used by SeaMonkey, so it should probably move those there.
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
status-firefox54: affected → ---
Comment on attachment 8939773 [details] Bug 1343837 - Remove find dialog resources from toolkit. https://reviewboard.mozilla.org/r/210082/#review215856 Looks good to me, thanks for the cleanup :-). This should land on inbound to avoid bitrot with bug 1356029.
Attachment #8939773 - Flags: review?(florian) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c28fb6a2c61a Remove find dialog resources from toolkit. r=florian
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/343de817418c Remove find dialog resources from toolkit: Remove moz.build rules for removed files to fix build bustage. r=bustage-fix on a CLOSED TREE
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/40ad3b14439f Remove find dialog resources from toolkit: Remove another moz.build rule for removed files to fix build bustage. r=bustage-fix on a CLOSED TREE
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/d63b4b5aab76 Remove find dialog resources from toolkit: Re-add moz.build rule for test files. DONTBUILD on a CLOSED TREE
https://hg.mozilla.org/mozilla-central/rev/c28fb6a2c61a https://hg.mozilla.org/mozilla-central/rev/343de817418c https://hg.mozilla.org/mozilla-central/rev/40ad3b14439f https://hg.mozilla.org/mozilla-central/rev/d63b4b5aab76
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.