Remove obsolete chrome://global/content/findUtils.js

RESOLVED FIXED in Firefox 59

Status

()

Toolkit
Find Toolbar
RESOLVED FIXED
a year ago
2 months ago

People

(Reporter: florian, Assigned: dao)

Tracking

Trunk
mozilla59
Points:
---

Firefox Tracking Flags

(firefox59 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

a year ago
chrome://global/content/findUtils.js is reported as unreferenced by my test in bug 1316187.

I can't find any use of it in our tree, and dxr doesn't seem to show current usage of it in add-ons. SeaMonkey uses its own fork of this file. I think we can just remove it.
I believe finddialog.xul, finddialog.dtd, finddialog.properties can be removed as well. Although finddialog.xul (and hence the .dtd and .properties) is used by SeaMonkey, so it should probably move those there.
(Assignee)

Updated

2 months ago
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
status-firefox54: affected → ---
Comment hidden (mozreview-request)
(Reporter)

Comment 3

2 months ago
mozreview-review
Comment on attachment 8939773 [details]
Bug 1343837 - Remove find dialog resources from toolkit.

https://reviewboard.mozilla.org/r/210082/#review215856

Looks good to me, thanks for the cleanup :-). This should land on inbound to avoid bitrot with bug 1356029.
Attachment #8939773 - Flags: review?(florian) → review+

Comment 4

2 months ago
Pushed by florian@queze.net:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c28fb6a2c61a
Remove find dialog resources from toolkit. r=florian

Comment 5

2 months ago
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/343de817418c
Remove find dialog resources from toolkit: Remove moz.build rules for removed files to fix build bustage. r=bustage-fix on a CLOSED TREE

Comment 6

2 months ago
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/40ad3b14439f
Remove find dialog resources from toolkit: Remove another moz.build rule for removed files to fix build bustage. r=bustage-fix on a CLOSED TREE

Comment 7

2 months ago
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d63b4b5aab76
Remove find dialog resources from toolkit: Re-add moz.build rule for test files. DONTBUILD on a CLOSED TREE

Comment 8

2 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c28fb6a2c61a
https://hg.mozilla.org/mozilla-central/rev/343de817418c
https://hg.mozilla.org/mozilla-central/rev/40ad3b14439f
https://hg.mozilla.org/mozilla-central/rev/d63b4b5aab76
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.