|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
59 bytes, text/x-review-board-request
|Details | Review|
chrome://global/content/url-classifier/unittests.xul is shipped on all 3 platforms, but that doesn't seem to be intentional. That file was removed 10 years ago at bug 387196 comment 15, but that patch got backed out (bug 387196 comment 16) for reasons that don't seem related to this file, and the file is never mentioned again in the bug comments.
I'm happy to mentor this bug. Here's a place to look for what to remove: http://searchfox.org/mozilla-central/search?q=unittests.xul&case=false®exp=false&path=
I've posted a patch for this. One thing I was a little unclear on: removing unittests.xul from toolkit/components/url-classifier/tests/jar.mn left it essentially empty - wasn't sure if jar.mn should therefore be removed as well. I left it in place but I can remove it if that's preferred.
(In reply to Steve Armand from comment #3) > I've posted a patch for this. Thanks! > One thing I was a little unclear on: removing > unittests.xul from toolkit/components/url-classifier/tests/jar.mn left it > essentially empty - wasn't sure if jar.mn should therefore be removed as > well. Yes, please. And also remove the reference to this jar.mn file at http://searchfox.org/mozilla-central/rev/2aa0806c598ec433e431728f5ddd3a6847c1a417/toolkit/components/url-classifier/tests/moz.build#12
Ok, I've made the update: removed jar.mn as well as the reference to the file in toolkit/components/url-classifier/tests/moz.build.
Comment on attachment 8903874 [details] Bug 1343843 - Remove unused chrome://global/content/url-classifier/unittests.xul. Thanks for the update, I can review this.
Comment on attachment 8903874 [details] Bug 1343843 - Remove unused chrome://global/content/url-classifier/unittests.xul. https://reviewboard.mozilla.org/r/175648/#review180902 This is great, thank you for the patch.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/a7c3203be89a Remove unused chrome://global/content/url-classifier/unittests.xul. r=standard8