Remove chrome://global/content/url-classifier/unittests.xul

RESOLVED FIXED in Firefox 57

Status

()

Toolkit
Safe Browsing
P3
normal
RESOLVED FIXED
9 months ago
2 months ago

People

(Reporter: florian, Assigned: Steve Armand, Mentored)

Tracking

({good-first-bug})

Trunk
mozilla57
good-first-bug
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox54 affected, firefox57 fixed)

Details

(Whiteboard: [lang=xul|js])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

9 months ago
chrome://global/content/url-classifier/unittests.xul is shipped on all 3 platforms, but that doesn't seem to be intentional.

That file was removed 10 years ago at bug 387196 comment 15, but that patch got backed out (bug 387196 comment 16) for reasons that don't seem related to this file, and the file is never mentioned again in the bug comments.
Keywords: good-first-bug
Priority: -- → P3
See Also: → bug 1297614
I'm happy to mentor this bug. Here's a place to look for what to remove:

http://searchfox.org/mozilla-central/search?q=unittests.xul&case=false&regexp=false&path=
Mentor: standard8@mozilla.com
Whiteboard: [lang=xul|js]
Comment hidden (mozreview-request)
(Assignee)

Comment 3

3 months ago
I've posted a patch for this. One thing I was a little unclear on: removing unittests.xul from toolkit/components/url-classifier/tests/jar.mn left it essentially empty - wasn't sure if jar.mn should therefore be removed as well. I left it in place but I can remove it if that's preferred.
(Reporter)

Comment 4

3 months ago
(In reply to Steve Armand from comment #3)
> I've posted a patch for this.

Thanks!

> One thing I was a little unclear on: removing
> unittests.xul from toolkit/components/url-classifier/tests/jar.mn left it
> essentially empty - wasn't sure if jar.mn should therefore be removed as
> well.

Yes, please. And also remove the reference to this jar.mn file at http://searchfox.org/mozilla-central/rev/2aa0806c598ec433e431728f5ddd3a6847c1a417/toolkit/components/url-classifier/tests/moz.build#12
Comment hidden (mozreview-request)
(Assignee)

Comment 6

3 months ago
Ok, I've made the update: removed jar.mn as well as the reference to the file in toolkit/components/url-classifier/tests/moz.build.
(Assignee)

Updated

3 months ago
Attachment #8903874 - Flags: review?(standard8) → review?(florian)
Comment on attachment 8903874 [details]
Bug 1343843 - Remove unused chrome://global/content/url-classifier/unittests.xul.

Thanks for the update, I can review this.
Attachment #8903874 - Flags: review?(florian) → review?(standard8)
Assignee: nobody → stevea1

Comment 8

3 months ago
mozreview-review
Comment on attachment 8903874 [details]
Bug 1343843 - Remove unused chrome://global/content/url-classifier/unittests.xul.

https://reviewboard.mozilla.org/r/175648/#review180902

This is great, thank you for the patch.
Attachment #8903874 - Flags: review?(standard8) → review+

Comment 9

3 months ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a7c3203be89a
Remove unused chrome://global/content/url-classifier/unittests.xul. r=standard8
https://hg.mozilla.org/mozilla-central/rev/a7c3203be89a
Status: NEW → RESOLVED
Last Resolved: 2 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.