Closed Bug 1343850 Opened 7 years ago Closed 7 years ago

JavaScript error: resource:///modules/PlacesProvider.jsm, line 118: ReferenceError: aTitle is not defined

Categories

(Firefox :: New Tab Page, defect)

53 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 54
Tracking Status
firefox53 --- fixed
firefox54 --- fixed

People

(Reporter: Gijs, Assigned: Gijs)

References

Details

Attachments

(1 file)

I thought I fixed this before landing, but it seems not. :-\
Comment on attachment 8842851 [details]
Bug 1343850 - fix PlacesProvider.jsm undefined variable (aLastKnownTitle vs. aTitle),

https://reviewboard.mozilla.org/r/116614/#review118620
Attachment #8842851 - Flags: review?(mak77) → review+
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/15651f8268b7
fix PlacesProvider.jsm undefined variable (aLastKnownTitle vs. aTitle), r=mak
Marking affected as we will likely need to uplift this to 53 to go with bug 1341097
Comment on attachment 8842851 [details]
Bug 1343850 - fix PlacesProvider.jsm undefined variable (aLastKnownTitle vs. aTitle),

Approval Request Comment
[Feature/Bug causing the regression]: bug 1341097
[User impact if declined]: errors in the console. I haven't seen any actual impact beyond that. I think this code is only used by remote new tab, which we don't use.
[Is this code covered by automated tests?]: apparently not, or it wouldn't have been landed as it was! But also, in general, yes, I guess.
[Has the fix been verified in Nightly?]: not really necessary given the patch
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: bug 1341097
[Is the change risky?]: no
[Why is the change risky/not risky?]: it's an obvious 1-line rename change for something that is clearly broken
[String changes made/needed]: no
Attachment #8842851 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/15651f8268b7
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Comment on attachment 8842851 [details]
Bug 1343850 - fix PlacesProvider.jsm undefined variable (aLastKnownTitle vs. aTitle),

Minor fix to go with uplift from bug 1341097. Let's bring this profile migration fix to aurora 53.
Attachment #8842851 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.