Closed
Bug 1343866
Opened 7 years ago
Closed 7 years ago
Scope more nsCOMPtrs in XRE_XPCShellMain()
Categories
(Testing :: XPCShell Harness, enhancement)
Testing
XPCShell Harness
Tracking
(firefox55 fixed)
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
Details
Attachments
(2 files)
|
9.12 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
|
3.23 KB,
patch
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8842860 -
Flags: review?(benjamin)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8842860 [details] [diff] [review] Scope more nsCOMPtrs in XRE_XPCShellMain() This is one that would be a lot easier to review in mozreview. Are there any changes within the indented portions, or can I have a -w version of the diff?
Flags: needinfo?(ehsan)
|
|
Assignee | |
Comment 3•7 years ago
|
||
(In reply to Benjamin Smedberg [:bsmedberg] from comment #2) > Comment on attachment 8842860 [details] [diff] [review] > Scope more nsCOMPtrs in XRE_XPCShellMain() > > This is one that would be a lot easier to review in mozreview. Are there any > changes within the indented portions, or can I have a -w version of the diff? There aren't any changes, mostly indentation changes, let me upload a diff -w for you.
Flags: needinfo?(ehsan)
|
|
Assignee | |
Comment 4•7 years ago
|
||
(FWIW I ended up fixing this to address some warnings I spotted in a log somewhere when debugging a test... By the time I wrote the fix I forgot where the errors are coming from, sorry for the vague bug report! But some code was warning about stuff being cleared too late.)
|
|
Assignee | |
Comment 5•7 years ago
|
||
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8844103 -
Attachment is patch: true
|
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → ehsan
|
|
||
Comment 6•7 years ago
|
||
Comment on attachment 8842860 [details] [diff] [review] Scope more nsCOMPtrs in XRE_XPCShellMain() LGTM!
Attachment #8842860 -
Flags: review?(benjamin) → review+
Pushed by eakhgari@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/fde4cd0aed6d Scope more nsCOMPtrs in XRE_XPCShellMain(); r=bsmedberg
|
||
Comment 8•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/fde4cd0aed6d
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•