Closed Bug 1343866 Opened 4 years ago Closed 4 years ago

Scope more nsCOMPtrs in XRE_XPCShellMain()

Categories

(Testing :: XPCShell Harness, enhancement)

enhancement
Not set
normal

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

Details

Attachments

(2 files)

No description provided.
Attachment #8842860 - Flags: review?(benjamin)
Comment on attachment 8842860 [details] [diff] [review]
Scope more nsCOMPtrs in XRE_XPCShellMain()

This is one that would be a lot easier to review in mozreview. Are there any changes within the indented portions, or can I have a -w version of the diff?
Flags: needinfo?(ehsan)
(In reply to Benjamin Smedberg [:bsmedberg] from comment #2)
> Comment on attachment 8842860 [details] [diff] [review]
> Scope more nsCOMPtrs in XRE_XPCShellMain()
> 
> This is one that would be a lot easier to review in mozreview. Are there any
> changes within the indented portions, or can I have a -w version of the diff?

There aren't any changes, mostly indentation changes, let me upload a diff -w for you.
Flags: needinfo?(ehsan)
(FWIW I ended up fixing this to address some warnings I spotted in a log somewhere when debugging a test...  By the time I wrote the fix I forgot where the errors are coming from, sorry for the vague bug report! But some code was warning about stuff being cleared too late.)
Attached patch diff -wSplinter Review
Attachment #8844103 - Attachment is patch: true
Assignee: nobody → ehsan
Comment on attachment 8842860 [details] [diff] [review]
Scope more nsCOMPtrs in XRE_XPCShellMain()

LGTM!
Attachment #8842860 - Flags: review?(benjamin) → review+
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fde4cd0aed6d
Scope more nsCOMPtrs in XRE_XPCShellMain(); r=bsmedberg
https://hg.mozilla.org/mozilla-central/rev/fde4cd0aed6d
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.