1343866 - Scope more nsCOMPtrs in XRE_XPCShellMain()

Status: RESOLVED FIXED

(Testing :: XPCShell Harness, enhancement)

Comment 1

[(no longer active)]

Attachment: Scope more nsCOMPtrs in XRE_XPCShellMain()

Comment 2

[Benjamin Smedberg]

Comment on attachment 8842860 [details] [diff] [review]
Scope more nsCOMPtrs in XRE_XPCShellMain()

This is one that would be a lot easier to review in mozreview. Are there any changes within the indented portions, or can I have a -w version of the diff?

Comment 3

[(no longer active)]

(In reply to Benjamin Smedberg [:bsmedberg] from comment #2)
> Comment on attachment 8842860 [details] [diff] [review]
> Scope more nsCOMPtrs in XRE_XPCShellMain()
> 
> This is one that would be a lot easier to review in mozreview. Are there any
> changes within the indented portions, or can I have a -w version of the diff?

There aren't any changes, mostly indentation changes, let me upload a diff -w for you.

Comment 4

[(no longer active)]

(FWIW I ended up fixing this to address some warnings I spotted in a log somewhere when debugging a test...  By the time I wrote the fix I forgot where the errors are coming from, sorry for the vague bug report! But some code was warning about stuff being cleared too late.)

Comment 5

[(no longer active)]

Attachment: diff -w

Comment 6

[Benjamin Smedberg]

Comment on attachment 8842860 [details] [diff] [review]
Scope more nsCOMPtrs in XRE_XPCShellMain()

LGTM!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fde4cd0aed6d
Scope more nsCOMPtrs in XRE_XPCShellMain(); r=bsmedberg

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/fde4cd0aed6d