1343873 - Notebooks using get_client_history are failing

Status: RESOLVED FIXED

(Data Platform and Tools :: General, enhancement, P1)

Description

[Mauro Doglio [:mdoglio]]

The python_moztelemetry library deprecated get_client_history some time ago.As a consequence the function has been removed. Notebooks using it should instead use http://python-moztelemetry.readthedocs.io/en/stable/userguide.html#moztelemetry.hbase.HBaseMainSummaryView.get.

Comment 1

[Mauro Doglio [:mdoglio]]

This bug affects the following jobs:
    blok_daily
    vtabs_daily
    minvid_daily jobs
    rrayborn-telemetry-scheduled-task jobs

Adding the authors to the needinfo

Comment 2

[Ilana]

Mauro, Can you be more specific about what we should expect? When rrayborn and I looked at the pipeline today for those experiments, all data up to the present appeared as expected. Additionally, at least one of those dashboards is deprecated with others to follow suit, so is this an anticipated change or one that we'd expect to already see? 

Also, I imagine get_client_history() and get() are referring to the get_pings() calls and Dataset API respectively (since we never called get_client_history() directly), correct?

Comment 3

[Mauro Doglio [:mdoglio]]

Those notebooks are still importing `get_client_history`, but that function is not available anymore. This is raising an exception in the execution of the first cell. The notebook runner tries to run the rest of the cells and those are running successfully; for this reason the dataset is generated. The job though is marked as failing because there is at least one cell with errors. For now atmo doesn't make much noise when a job fails, but once [1] and [2] get fixed, you will receive an email whenever one of your jobs fail and the job details page on atmo will show the failed job runs. 

Long story short, could you please remove `get_client_history` from the import list in the first cell? :)

[1]https://github.com/mozilla/telemetry-analysis-service/issues/201
[2]https://github.com/mozilla/telemetry-analysis-service/issues/271

Comment 4

[Ilana]

Removed, as well as references to get_records which was also causing issues

Comment 5

[Mauro Doglio [:mdoglio]]

Thank you Ilana, I'll wait for rrayborn to update his notebook before I call this fixed.

Comment 6

[Mauro Doglio [:mdoglio]]

I had a look at the only job owned by :rrayborn on atmo and I see it's not failing anymore.