134388 - Starting Mozilla with option and url together doesn't work

Status: VERIFIED DUPLICATE of bug 74303

(Core Graveyard :: Cmd-line Features, defect)

Description

[Hakon]

I try to change the init string in the GNOME-panel launcher for mozilla, from
"/usr/bin/mozilla " to "/usr/bin/mozilla -splash http://website.net/ " but it
doesn't work. The splash shows, but it's still the start page defined in the
preferences that shows.
Removing the "-splash" will make it work, but shouldn't it work anyway?

Comment 1

[Andrew Schultz]

confirming with Linux build 20020329.  -splash is the only one that seems to
cause problems.

Comment 2

[Andrew Schultz]

http://lxr.mozilla.org/seamonkey/source/xpfe/appshell/src/nsCommandLineService.cpp#164

156         if (i == (aArgc-1)) {
157          /* This is the last argument and a URL 
158             * Append a PR_TRUE for the previous option in the value array
159             */
160            //mArgValueList.AppendElement((void *)PL_strdup("1"));
161            //mArgCount++;
162 
163            // Append the url to the arrays
164            //mArgList.AppendElement((void *)PL_strdup("-url"));
165            mArgValueList.AppendElement(ProcessURLArg(aArgv[i]));
166            mArgCount++;
167            continue;
168         }

the code to fix this bug is explicitly commented out... one would assume there
would be a good reason for that, but I don't know what it would be.

This bug occurs whenever an option without a value (--no-xshm, --display=____,
etc)  is used right before the url.  if the argument is not the next-to-the-last
argument, things work fine:

mozilla -splash -P profilename http://website.net/

the code being commented out is also responsible for bug 40481, bug 95977, bug
109765 and bug 111491

Comment 3

[Andrew Schultz]

It's commented out to prevent

mozilla -P profilename

from trying to make "profilename" into a URL
duh.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Just dup this to one of the bugs from comment #2 (in fact, dup them all to a 
single bug about the whole issue).

Comment 5

[Andrew Schultz]

*** This bug has been marked as a duplicate of 74303 ***

Comment 6

[sairuh (rarely reading bugmail)]

marking verified as a duplicate.

if you decide to reopen this bug, please clarify why.

search string for bugspam removal: SalviaGuaranitica