Closed Bug 1343888 Opened 7 years ago Closed 7 years ago

Add more MDN HTTP pages to mdn-utils.js

Categories

(DevTools :: Netmonitor, enhancement)

enhancement
Not set
normal

Tracking

(firefox54 fixed)

RESOLVED FIXED
Firefox 54
Tracking Status
firefox54 --- fixed

People

(Reporter: fs, Assigned: fs)

Details

Attachments

(1 file, 1 obsolete file)

I've written more docs on MDN for the new [Learn more] links in the netmonitor.

https://developer.mozilla.org/en-US/docs/Web/HTTP/Status$children has a json of all statuses. I compared subpages.length with SUPPORTED_HTTP_CODES.length to make sure I got them all.

I did the same for https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers$children and SUPPORTED_HEADERS.length
Assignee: nobody → fscholz
Attachment #8842886 - Flags: review?(odvarko)
Noticed that we miss the GA parameters for the status codes. Added that.
Attachment #8842886 - Attachment is obsolete: true
Attachment #8842886 - Flags: review?(odvarko)
Attachment #8842973 - Flags: review?(odvarko)
Comment on attachment 8842973 [details] [diff] [review]
Bug 1343888 – Add more MDN HTTP pages to mdn-utils.js

Review of attachment 8842973 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks for working on this!

Honza
Attachment #8842973 - Flags: review?(odvarko) → review+
Thanks for the quick review, Honza!
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c3e6f013c771
– Add more MDN HTTP pages to mdn-utils.js; r=Honza
Keywords: checkin-needed
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e090bd2b732c
Add more MDN HTTP pages to mdn-utils.js: wrap statement on two lines to make eslint happy. r=eslint-fix
https://hg.mozilla.org/mozilla-central/rev/c3e6f013c771
https://hg.mozilla.org/mozilla-central/rev/e090bd2b732c
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.