1343913 - required signoffs should be shown immediately

Status: RESOLVED WONTFIX

(Release Engineering Graveyard :: Applications: Balrog (frontend), enhancement, P3)

Description

[[e-mail] (:bhearsum)]

Currently, when a new Scheduled Change that requires signoff is added, a page refresh is required to have the signoffs it requires be shown. For most use cases this isn't a big deal, because Scheduled Changes are shown on a different page than where a change is Scheduled, but it's a pretty big papercut. The best way to see this is to schedule a change for a new Rule. You'll see "Before it can be enacted, this change must be signed off on by:", but nothing below it.

This happens beacuse the endpoint that lets you schedule things (https://github.com/mozilla/balrog/blob/master/auslib/admin/views/scheduled_changes.py#L67) does not return information about the required signoffs, whereas the endpoint that returns all existing scheduled changes (https://github.com/mozilla/balrog/blob/master/auslib/admin/views/scheduled_changes.py#L23) does.

We should probably also return required signoffs when modifying a scheduled change) https://github.com/mozilla/balrog/blob/master/auslib/admin/views/scheduled_changes.py#L91, because doing so may change what is required.

Comment 1

[[e-mail] (:bhearsum)]

I need to unassign this for now because I don't have the time to take on any additional mentoring/reviewing at the moment. Sorry =\

Comment 2

[Collins Abitekaniza]

(In reply to Ben Hearsum (:bhearsum) from comment #1)
> I need to unassign this for now because I don't have the time to take on any
> additional mentoring/reviewing at the moment. Sorry =\

It's alright :)

Comment 3

[[e-mail] (:bhearsum)]

We're currently working on a new version of the UI, and bugs like this are unlikely to be fixed in the current one.