required signoffs should be shown immediately

NEW
Unassigned

Status

Release Engineering
Balrog: Frontend
P3
normal
a year ago
3 months ago

People

(Reporter: bhearsum, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [lang=python][ready])

(Reporter)

Description

a year ago
Currently, when a new Scheduled Change that requires signoff is added, a page refresh is required to have the signoffs it requires be shown. For most use cases this isn't a big deal, because Scheduled Changes are shown on a different page than where a change is Scheduled, but it's a pretty big papercut. The best way to see this is to schedule a change for a new Rule. You'll see "Before it can be enacted, this change must be signed off on by:", but nothing below it.

This happens beacuse the endpoint that lets you schedule things (https://github.com/mozilla/balrog/blob/master/auslib/admin/views/scheduled_changes.py#L67) does not return information about the required signoffs, whereas the endpoint that returns all existing scheduled changes (https://github.com/mozilla/balrog/blob/master/auslib/admin/views/scheduled_changes.py#L23) does.

We should probably also return required signoffs when modifying a scheduled change) https://github.com/mozilla/balrog/blob/master/auslib/admin/views/scheduled_changes.py#L91, because doing so may change what is required.
(Reporter)

Updated

9 months ago
Priority: P2 → P3
(Reporter)

Updated

9 months ago
Mentor: bhearsum
(Reporter)

Updated

8 months ago
Mentor: bhearsum

Updated

4 months ago
Assignee: nobody → collins.abitekaniza
(Reporter)

Comment 1

4 months ago
I need to unassign this for now because I don't have the time to take on any additional mentoring/reviewing at the moment. Sorry =\
Assignee: collins.abitekaniza → nobody

Comment 2

3 months ago
(In reply to Ben Hearsum (:bhearsum) from comment #1)
> I need to unassign this for now because I don't have the time to take on any
> additional mentoring/reviewing at the moment. Sorry =\

It's alright :)
You need to log in before you can comment on or make changes to this bug.