1343953 - Add support for unsigned/signed tasks in release runner and releasetasks

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, enhancement, P1)

Description

[Rail Aliiev [:rail]]

TC based CI builds use separate tasks for signed and unsigned bits. We need to teach release runner and releasetasks how to deal with these.

In a way this is a reincarnation of bug 1339151 to make reviews prettier. :/

Comment 1

[Rail Aliiev [:rail]]

Attachment: Bug 1343953 - Add support for unsigned/signed tasks

Review commit: https://reviewboard.mozilla.org/r/116682/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/116682/

Comment 2

[Rail Aliiev [:rail]]

Attachment: releasetasks

Comment 3

[Jordan Lund (:jlund)]

Comment on attachment 8842962 [details]
Bug 1343953 - Add support for unsigned/signed tasks

https://reviewboard.mozilla.org/r/116682/#review118534

lgtm. we do a few findTask() calls for both signed and unsigned. If we have to do anymore, we should probably make the `unsigned_task` and `signed_task` a global lookup that gets passed around during release runner run.

::: lib/python/kickoff/build_status.py:78
(Diff revision 1)
> -                task_id = task_for_revision(
> -                    self.taskcluster_index, self.branch, self.revision, self.taskcluster_product_name, platform
> -                )['taskId']
> +                # Assuming that the signed tasks are completed after their
> +                # unsigned counterparts
> +                route = self.tc_task_indexes[platform]['signed'].format(
> +                    rev=self.revision)
> +                task_id = self.taskcluster_index.findTask(route)['taskId']
>                  # Bug 1307326 - consider only tasks indexed with rank > 0

maybe update comment to say `or if rank is unknown, tasks that are tier 1`

Comment 4

[Rail Aliiev [:rail]]

Comment on attachment 8842962 [details]
Bug 1343953 - Add support for unsigned/signed tasks

https://hg.mozilla.org/build/tools/rev/f39221db0f03836526605b29443186583afe701d

Comment 5

[Rail Aliiev [:rail]]

Comment on attachment 8842963 [details] [review]
releasetasks

merged

Comment 6

[Rail Aliiev [:rail]]

tests fixed: https://hg.mozilla.org/build/tools/rev/2bcf63ce095bccee48477a5b365a5a8fe7746e85

Comment 7

[Rail Aliiev [:rail]]

Deployed on bm85