Add support for unsigned/signed tasks in release runner and releasetasks

RESOLVED FIXED

Status

enhancement
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: rail, Assigned: rail)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

TC based CI builds use separate tasks for signed and unsigned bits. We need to teach release runner and releasetasks how to deal with these.

In a way this is a reincarnation of bug 1339151 to make reviews prettier. :/
Posted file releasetasks
Attachment #8842963 - Flags: review?(jlund)
Comment on attachment 8842962 [details]
Bug 1343953 - Add support for unsigned/signed tasks

https://reviewboard.mozilla.org/r/116682/#review118534

lgtm. we do a few findTask() calls for both signed and unsigned. If we have to do anymore, we should probably make the `unsigned_task` and `signed_task` a global lookup that gets passed around during release runner run.

::: lib/python/kickoff/build_status.py:78
(Diff revision 1)
> -                task_id = task_for_revision(
> -                    self.taskcluster_index, self.branch, self.revision, self.taskcluster_product_name, platform
> -                )['taskId']
> +                # Assuming that the signed tasks are completed after their
> +                # unsigned counterparts
> +                route = self.tc_task_indexes[platform]['signed'].format(
> +                    rev=self.revision)
> +                task_id = self.taskcluster_index.findTask(route)['taskId']
>                  # Bug 1307326 - consider only tasks indexed with rank > 0

maybe update comment to say `or if rank is unknown, tasks that are tier 1`
Attachment #8842962 - Flags: review?(jlund) → review+
Attachment #8842963 - Flags: review?(jlund) → review+
Comment on attachment 8842963 [details] [review]
releasetasks

merged
Attachment #8842963 - Flags: checked-in+
Deployed on bm85
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.