Closed Bug 1343961 Opened 9 years ago Closed 4 years ago

Autoland should clear the checkin-needed keyword when it can't rebase and push

Categories

(Conduit :: Lando, enhancement, P3)

Product:
Conduit
Component:
Lando
Type:
enhancement

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: RyanVM, Unassigned)

References

Details

(Keywords: conduit-triaged)

+++ This bug was initially created as a clone of Bug #1318402 +++ Bug 1318402 has Autoland successfully commenting in bugs when it can't rebase and land a patch. However, it still leaves the checkin-needed keyword set on the bug, which signals that there's a patch ready for landing. It would be great if that was also removed at the time of commenting.
Product: MozReview → Conduit
Component: Transplant → Lando
Keywords: conduit-triaged
Whiteboard: [lando-backlog]
Keywords: conduit-backlog
Whiteboard: [lando-backlog]
Keywords: conduit-backlog
Priority: -- → P3

I guess this is obsolete nowadays?

Flags: needinfo?(glob)

I suspect it's still needed, somewhere. Not sure if Lando should do this, or PulseBot, or Bugzilla directly.

Redirecting to Zeid.

Flags: needinfo?(glob) → needinfo?(zeid)

Currently, the checkin-needed tag is removed from the Phabricator revision when a landing is queued. I believe this is the last thing that Lando does with these tags, so the tags no longer exist by the time the landing job is queued. Any failure has no additional impact on these tags.

Sounds that this bug was referring to Bugzilla keywords, and not Phabricator tags? I believe the checkin-needed keyword is deprecated in Bugzilla, thus Comment 1 may be accurate.

Flags: needinfo?(zeid)

Sounds like we're good if it's being removed from the Phabricator revision as soon as the landing is queued. Thanks!

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.