Create minimal hotfix add-on in order to remove the websense hotfix add-on

RESOLVED FIXED

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: rstrong, Assigned: rstrong)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

We are using system add-ons for this and it would be a good thing to remove this so it is no longer changing the update url along with the system add-on.
Created attachment 8843011 [details] [diff] [review]
patch
Attachment #8843011 - Flags: review?(felipc)
Not sure if this is the proper way to go but I went with the same compatibility info as the previous hotfix
Comment on attachment 8843011 [details] [diff] [review]
patch

Review of attachment 8843011 [details] [diff] [review]:
-----------------------------------------------------------------

Also needs to add a brief description of this in the root README file.

::: v20170302.01/bootstrap.js
@@ +10,5 @@
> +  uninstallHotfix(data);
> +}
> +
> +function startup(data, reason) {
> +  uninstallHotfix(data);

In order to not cause any trouble to the AddonManager by calling uninstall on the same addon twice, I'd be more comfortable with just leaving this call and removing it from install().

::: v20170302.01/install.rdf
@@ +18,5 @@
> +      <Description>
> +        <!-- Firefox -->
> +        <em:id>{ec8030f7-c20a-464f-9b0e-13a3a9e97384}</em:id>
> +        <em:minVersion>39.0</em:minVersion>
> +        <em:maxVersion>47.*</em:maxVersion>

We bumped this manually on AMO to 48, so this should at least be 48.*.

But interestingly, right now it says on AMO that it's marked as compatible with 52.*.  ( https://addons.mozilla.org/en-US/firefox/addon/firefox-hotfix/versions/?page=1#version-20160826.01 ).  I wonder if this is a bug on AMO, as it shouldn't be bumping (I believe) an addon with strictCompatibility = true.

So now I don't know what to recommend about it, but I guess the best will be to use 52.*
Attachment #8843011 - Flags: review?(felipc) → feedback+
Created attachment 8843019 [details] [diff] [review]
patch rev2
Attachment #8843011 - Attachment is obsolete: true
Attachment #8843019 - Flags: review?(felipc)
Attachment #8843019 - Flags: review?(felipc) → review+
Felipe, not sure what the next steps are for this. If you are willing to drive this in or provide me with the next steps I'd appreciate it. Thanks!

BTW: the AMO issue with this being compatible with 52 is an example of why I would like this gone... too many moving parts and edgecases.
Flags: needinfo?(felipc)
Over irc Felipe said he will drive the remainder of this in a new bug. Thanks Felipe!
Assignee: nobody → robert.strong.bugs
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Flags: needinfo?(felipc)
Resolution: --- → FIXED
Summary: Deploy minimal hotfix add-on in order to remove the websense hotfix add-on → Create minimal hotfix add-on in order to remove the websense hotfix add-on
You need to log in before you can comment on or make changes to this bug.