Closed
Bug 1343984
Opened 7 years ago
Closed 7 years ago
Make webrender_bindings fail on warnings
Categories
(Core :: Graphics: WebRender, enhancement, P3)
Tracking
()
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: kats, Assigned: kats)
Details
(Whiteboard: [gfx-noted])
Attachments
(3 files)
Warnings are bad. And they've been increasing in quantity. We should stem the tide while it's still easy.
Assignee | ||
Comment 1•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=da752c0386951cce4099d3643ab4ecb337e8708b
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8843032 [details] Bug 1343984 - Fix trivial webrender_bindings warnings. https://reviewboard.mozilla.org/r/116778/#review118426
Attachment #8843032 -
Flags: review?(jmuizelaar) → review+
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8843033 [details] Bug 1343984 - Comment out the unused WrExternalImageIdType stuff as it produces hard-to-remove webrender_bindings warnings. https://reviewboard.mozilla.org/r/116780/#review118428
Attachment #8843033 -
Flags: review?(jmuizelaar) → review+
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8843034 [details] Bug 1343984 - Turn on warnings-as-errors for webrender_bindings. https://reviewboard.mozilla.org/r/116782/#review118432
Attachment #8843034 -
Flags: review?(jmuizelaar) → review+
Pushed by kgupta@mozilla.com: https://hg.mozilla.org/projects/graphics/rev/80ea84e1b502 Fix trivial webrender_bindings warnings. r=jrmuizel https://hg.mozilla.org/projects/graphics/rev/ead89e056556 Comment out the unused WrExternalImageIdType stuff as it produces hard-to-remove webrender_bindings warnings. r=jrmuizel https://hg.mozilla.org/projects/graphics/rev/c83b1eec0a12 Turn on warnings-as-errors for webrender_bindings. r=jrmuizel
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 9•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/80ea84e1b502 https://hg.mozilla.org/mozilla-central/rev/ead89e056556 https://hg.mozilla.org/mozilla-central/rev/c83b1eec0a12
status-firefox54:
--- → fixed
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•