Open Bug 1344026 Opened 3 years ago Updated 6 months ago

Make it easier to get WR recordings from try pushes

Categories

(Core :: Graphics: WebRender, enhancement, P3)

54 Branch
enhancement

Tracking

()

Tracking Status
firefox54 --- affected
firefox56 --- unaffected
firefox57 --- unaffected

People

(Reporter: kats, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [gfx-noted])

It's possible to turn on webrender recording by setting ENABLE_RECORDING [1] to true. However this dumps the recording files (one per webrender instance) into whatever is the current working directory at the time the code runs. For intermittent failures and the like, it would be useful to get recordings by doing try pushes and retriggering until the problem reproduces. This is straightforward enough, but then we need a way to get the recordings back. Putting them into the folder pointed to by the environment variable MOZ_UPLOAD_DIR should do it, I think. Try push to attempt this is at [2].

[1] http://searchfox.org/mozilla-central/rev/546a05fec017cb785fca62a5199d42812a6a1fd3/gfx/webrender_bindings/src/bindings.rs#22
[2] https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d0e39ad5cd3dbc0f25f25a0cdbd5c10cbc63646
Actually this might be a bad idea. The recording files from a job like crashtest can be huge (multiple gigabytes). Maybe eventually we can chop it up so that we generate a recording file per test, overwiting old ones, and then just save the most recent one if there's an error or failure or something.
Assignee: bugmail → nobody
You need to log in before you can comment on or make changes to this bug.