1344039 - upload-symbols job fails when using artifact builds on try

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

I am using artifact builds locally, and recent changes are triggering them on try as well.

It appears this causes job failures in:

build-linux64/opt-upload-symbols
build-linux64/debug-upload-symbols

The failure summary says:

ERROR 404: Not Found.

An example log:

https://treeherder.mozilla.org/logviewer.html#?job_id=81269779&repo=try

An example try run:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e1f82efc53ffc4ff26e4c596fb681aacad85f9ff

Comment 1

[Chris Manchester (limited bugmail, email directly)]

According to Ted this job shouldn't really be running on Try at all at this point, I'll see about un-scheduling it.

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Attachment: Bug 1344039 - Don't schedule symbol uploading on try jobs.

Review commit: https://reviewboard.mozilla.org/r/117218/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/117218/

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8843490 [details]
Bug 1344039 - Don't schedule symbol uploading on try jobs.

https://reviewboard.mozilla.org/r/117218/#review119234

::: taskcluster/taskgraph/transforms/upload_symbols.py:21
(Diff revision 1)
> +        if task['run-on-projects'] == ['try']:
> +            continue

All upload-symbols tasks have this set, since it's the default in `taskcluster/ci/upload-symbols/job-template.yml`.  So with this change, these jobs will never run (on any branch).

Comment 4

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8843490 [details]
Bug 1344039 - Don't schedule symbol uploading on try jobs.

https://reviewboard.mozilla.org/r/117218/#review119234

> All upload-symbols tasks have this set, since it's the default in `taskcluster/ci/upload-symbols/job-template.yml`.  So with this change, these jobs will never run (on any branch).

Ok, how can I skip these on try? Should I do it based on GECKO_HEAD_REPOSITORY?

Comment 5

[Chris Manchester (limited bugmail, email directly)]

Setting needinfo re comment 4

Comment 6

[Dustin J. Mitchell [:dustin] (he/him)]

I seem to recall we explicitly *enabled* upload symbols builds on try.  But maybe the tides have turned!

The way to remove jobs on a particular branch is generally in the target task selection process. For try, that's implemented in `taskcluster/taskgraph/try_option_syntax.py`, and there's a nice list of the "BUILD_TASKS" that it will schedule based on their build platform. `upload-symbols` is a part of that list.  Removing that list entry should have the desired effect.

Comment 7

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8843490 [details]
Bug 1344039 - Don't schedule symbol uploading on try jobs.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/117218/diff/1-2/

Comment 8

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8843490 [details]
Bug 1344039 - Don't schedule symbol uploading on try jobs.

https://reviewboard.mozilla.org/r/117218/#review119632

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1475fe1bf157
Don't schedule symbol uploading on try jobs. r=dustin

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1475fe1bf157