1344073 - HTMLMediaElement::MozRequestDebugInfo creates debug dump string with inconsistent formatting

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement)

Description

[Karolien]

The string created by HTMLMediaElement::MozRequestDebugInfo alternates its use of colons and equals signs between key-value pairs. This can make it difficult to parse the string to other formats by the method caller.

Comment 1

[Karolien]

Attachment: Bug 1344073 - Adding consistent formatting to HTMLMediaElement::MozRequestDebugInfo debugInfo dump string.

Review commit: https://reviewboard.mozilla.org/r/116894/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/116894/

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8843137 [details]
Bug 1344073 - Adding consistent formatting to HTMLMediaElement::MozRequestDebugInfo debugInfo dump string.

https://reviewboard.mozilla.org/r/116894/#review118532

Comment 3

[Karolien]

I might not be around to resolve this if it doesn't land could you please take a look, thanks!

Comment 4

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s dcdc29c03cd8 -d edf005cc0946: rebasing 379380:dcdc29c03cd8 "Bug 1344073 - Adding consistent formatting to HTMLMediaElement::MozRequestDebugInfo debugInfo dump string. r=cpearce" (tip)
merging dom/media/MediaDecoder.cpp
merging dom/media/MediaDecoderStateMachine.cpp
merging dom/media/MediaFormatReader.cpp
merging dom/media/eme/MediaKeys.cpp
merging dom/media/mediasource/MediaSourceDemuxer.cpp
warning: conflicts while merging dom/media/MediaFormatReader.cpp! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 5

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s dcdc29c03cd8 -d 3436c6cf4123: rebasing 379412:dcdc29c03cd8 "Bug 1344073 - Adding consistent formatting to HTMLMediaElement::MozRequestDebugInfo debugInfo dump string. r=cpearce" (tip)
merging dom/media/MediaDecoder.cpp
merging dom/media/MediaDecoderStateMachine.cpp
merging dom/media/MediaFormatReader.cpp
merging dom/media/eme/MediaKeys.cpp
merging dom/media/mediasource/MediaSourceDemuxer.cpp
warning: conflicts while merging dom/media/MediaFormatReader.cpp! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 6

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1344073 - Adding consistent formatting to HTMLMediaElement::MozRequestDebugInfo debugInfo dump string.

Review commit: https://reviewboard.mozilla.org/r/117978/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/117978/

Comment 7

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Looks like I've created a new rather than updating the old one -_- The new review fixes the conflicts and handles the new info being dumped in MediaFormatReader, aside from that they are the same.

Comment 8

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8844582 [details]
Bug 1344073 - Adding consistent formatting to HTMLMediaElement::MozRequestDebugInfo debugInfo dump string.

https://reviewboard.mozilla.org/r/117978/#review119896

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d7d6684b3ad0
Adding consistent formatting to HTMLMediaElement::MozRequestDebugInfo debugInfo dump string. r=cpearce

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d7d6684b3ad0