Closed
Bug 1344102
Opened 7 years ago
Closed 7 years ago
Add a more restricted xml:base telemetry
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla54
People
(Reporter: xidorn, Assigned: xidorn)
References
Details
Attachments
(1 file)
59 bytes,
text/x-review-board-request
|
bzbarsky
:
review+
lizzard
:
approval-mozilla-aurora+
|
Details |
No description provided.
Assignee | ||
Updated•7 years ago
|
Summary: Restrict xml:base telemetry counter to nsStyledElement → Add a more restricted xml:base telemetry
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → xidorn+moz
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8843174 [details] Bug 1344102 - Add a telemetry for xml:base on styled element. https://reviewboard.mozilla.org/r/116936/#review118566 r=me ::: dom/base/FragmentOrElement.cpp:393 (Diff revision 1) > elem = elem->GetParent(); > } while(elem); > > if (!baseAttrs.IsEmpty()) { > doc->WarnOnceAbout(nsIDocument::eXMLBaseAttribute); > + if (nsCOMPtr<nsStyledElement> styled = You could also just check IsSVGElement() || IsHTMLElement() || IsXULElement(). Might be faster and without const_cast.
Attachment #8843174 -
Flags: review+
Comment hidden (mozreview-request) |
Pushed by xquan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/823956575ed2 Add a telemetry for xml:base on styled element. r=bz
Assignee | ||
Comment 5•7 years ago
|
||
Comment on attachment 8843174 [details] Bug 1344102 - Add a telemetry for xml:base on styled element. Approval Request Comment [Feature/Bug causing the regression]: not a regression [User impact if declined]: no, but we want to have more data for removing xml:base support [Is this code covered by automated tests?]: no [Has the fix been verified in Nightly?]: no, but the probe added in bug 1340926 which is mostly identical thing has been landed in aurora for a while [Needs manual test from QE? If yes, steps to reproduce]: no [List of other uplifts needed for the feature/fix]: none [Is the change risky?]: no [Why is the change risky/not risky?]: it just adds another telemetry probe on top of what was added in bug 1340926. [String changes made/needed]: none
Attachment #8843174 -
Flags: approval-mozilla-aurora?
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/823956575ed2
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Updated•7 years ago
|
status-firefox53:
--- → affected
Comment 7•7 years ago
|
||
Comment on attachment 8843174 [details] Bug 1344102 - Add a telemetry for xml:base on styled element. Let's uplift this to aurora now so we get better data for 53 once it moves to beta.
Attachment #8843174 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 8•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/e11b1a808700
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•