Adding shouldComponentUpdate for all request-list-column-* components

RESOLVED WONTFIX

Status

RESOLVED WONTFIX
2 years ago
8 months ago

People

(Reporter: rickychien, Assigned: rickychien)

Tracking

(Depends on: 1 bug)

unspecified
Bug Flags:
qe-verify -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Performance is definitelly our top priority in netmonitor. See https://bugzilla.mozilla.org/show_bug.cgi?id=1308441#c64.

Adding shouldComponentUpdate check to reduce unnecessary component update when receiving irrelative props changes.
No longer depends on: 1308441
Depends on: 1308441
Blocks: 1307743
Flags: qe-verify?
Whiteboard: [netmonitor][triage] → [netmonitor] [triage]
Comment hidden (mozreview-request)
This patch only work on top of a series of patches in bug 1308441.
Flags: qe-verify? → qe-verify-
Priority: -- → P1
Whiteboard: [netmonitor] [triage] → [netmonitor]
Iteration: --- → 54.3 - Mar 6
Whiteboard: [netmonitor] → [netmonitor-reserve]
(In reply to Ricky Chien [:rickychien] from comment #2)
> This patch only work on top of a series of patches in bug 1308441.

It could be useful to land the refactoring-part of the bug 1308441 so,
this patch doesn't have to wait for react-virtualized.
I'll let you to decide.

Honza
Oh, the current implementation has used shouldComponentUpdate for every column components http://searchfox.org/mozilla-central/source/devtools/client/netmonitor/components/request-list-item.js#80-83.

My react-virtualized patch doesn't support that at the beginning and I'd prefer to put it back in this separate patch. As a result, this patch must depend on bug 1308441.
Close this bug and this patch will merge in bug 1308441 to solve performance regression.
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → WONTFIX
No longer blocks: 1307743
Iteration: 54.3 - Mar 6 → ---
Priority: P1 → --
Whiteboard: [netmonitor-reserve]
Attachment #8843189 - Flags: review?(odvarko)

Updated

8 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.