1344107 - Adding shouldComponentUpdate for all request-list-column-* components

Status: RESOLVED WONTFIX

(DevTools :: Netmonitor, defect)

Description

[Ricky Chien [:rickychien] (inactive)]

Performance is definitelly our top priority in netmonitor. See https://bugzilla.mozilla.org/show_bug.cgi?id=1308441#c64.

Adding shouldComponentUpdate check to reduce unnecessary component update when receiving irrelative props changes.

Comment 1

[Ricky Chien [:rickychien] (inactive)]

Attachment: Bug 1344107 - Adding shouldComponentUpdate for request-list-column-*

Review commit: https://reviewboard.mozilla.org/r/116962/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/116962/

Comment 2

[Ricky Chien [:rickychien] (inactive)]

This patch only work on top of a series of patches in bug 1308441.

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Ricky Chien [:rickychien] from comment #2)
> This patch only work on top of a series of patches in bug 1308441.

It could be useful to land the refactoring-part of the bug 1308441 so,
this patch doesn't have to wait for react-virtualized.
I'll let you to decide.

Honza

Comment 4

[Ricky Chien [:rickychien] (inactive)]

Oh, the current implementation has used shouldComponentUpdate for every column components http://searchfox.org/mozilla-central/source/devtools/client/netmonitor/components/request-list-item.js#80-83.

My react-virtualized patch doesn't support that at the beginning and I'd prefer to put it back in this separate patch. As a result, this patch must depend on bug 1308441.

Comment 5

[Ricky Chien [:rickychien] (inactive)]

Close this bug and this patch will merge in bug 1308441 to solve performance regression.