Closed Bug 1344120 Opened 3 years ago Closed 6 months ago
[translate] Reset search placeholder if filter selection not applied
44 bytes, text/x-github-pull-request
|Details | Review|
After selecting some filter, user must click the Apply x filters. I think it should be done automatically when user closes the selection bar.
If I understand correctly, we have the following problem: 1. Select a Missing filter with checkbox. 2. Close the filter menu by clicking outside of it. 3. The search placeholder reflects the Missing filter selection, but the filters aren't applied. If you start searching, you only search Missing filters. -- We should either apply the selected filters when the filter menu is closed or reset the search placeholder to reflect previously applied filter. Is that correct?
Status: UNCONFIRMED → NEW
Ever confirmed: true
(In reply to YF (Yang) from comment #2) > Yes. Thanks for confirming. I would actually suggest we go with the 2nd option here: reset search placeholder on filter menu close, unless you explicitly click the "Apply x filters" button or enter the Search field. (In reply to Michal Stanke (Mozilla.cz) [:MikkCZ] (off until 05/2017, use needinfo) from comment #3) > Can we do similar for the main navigation, i.e. get rid of the "Go" button? Maybe in the Resources menu only? If you change locale or project, there's a high chance you want to change the resource, too. Which means a high chance for an unnecessary request (and waiting). Of course, making Resource menu behave differently than the other two menus should also be reflected in styling.
Priority: -- → P3
See Also: → 1344457
Summary: [translate] automatic apply filters will be better → [translate] Reset search placeholder if fitler selection not applied
Assignee: nobody → michaelumanah
Status: NEW → ASSIGNED
Summary: [translate] Reset search placeholder if fitler selection not applied → [translate] Reset search placeholder if filter selection not applied
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.