1344143 - Revert bug 1200494 before Android INTL disabling becomes effective

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Download Manager, defect)

Description

[Jan Henning [:JanH]]

Part 1 of bug 1200494 (https://hg.mozilla.org/mozilla-central/rev/e07ec12de6c0) needs to be backed out again before bug 1343744 hits Beta/Release, otherwise we'll break the downloads list (and xpcshell tests as well).

Comment 1

[Jan Henning [:JanH]]

I've tried disabling the Intl API on a try build to check that the downloadutils xpcshell tests still work as expected (since they previously weren't enabled), but I'm only getting a broken build:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2526287a0ae6f91bf736c726d9f79d56c649e150

Comment 2

[Jan Henning [:JanH]]

Attachment: Bug 1344143 - Backing out changeset e07ec12de6c0 (Bug 1200494).

The Intl API is not being immediately enabled on Android Beta/Release after all, so we have to keep these fallbacks for the time being.

Review commit: https://reviewboard.mozilla.org/r/120242/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/120242/

Comment 3

[Jan Henning [:JanH]]

Download xpcshell tests still pass:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=68413037ea33b83c9cd2ecec8ebe8212fa28786f

Comment 4

[Marco Bonardo [:mak]]

Comment on attachment 8847241 [details]
Bug 1344143 - Backing out changeset e07ec12de6c0 (Bug 1200494).

https://reviewboard.mozilla.org/r/120242/#review122240

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b57650ab9be8
Backing out changeset e07ec12de6c0 (Bug 1200494). r=mak

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b57650ab9be8 backed also from m-c

Comment 7

[Makoto Kato [:m_kato]]

Could you request uplift to aurora?  Fennec 54 will still turn off ICU...

Comment 8

[Jan Henning [:JanH]]

Comment on attachment 8847241 [details]
Bug 1344143 - Backing out changeset e07ec12de6c0 (Bug 1200494).

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1343725
[User impact if declined]: Intl API is not coming to Beta/Release after all for the time being - without this patch, the download manager will be broken.
[Is this code covered by automated tests?]: Yes.
[Has the fix been verified in Nightly?]: Yes.
[Needs manual test from QE? If yes, steps to reproduce]: No.
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: No.
[Why is the change risky/not risky?]: Straight backout of bug 1200494 except for adjusted bug numbers for followup.
[String changes made/needed]: none

Comment 9

[Jan Henning [:JanH]]

Maybe this needs marking as fixed for the uplift request to show up wherever it needs to show up?

Comment 10

[Gerry Chang [:gchang]]

Comment on attachment 8847241 [details]
Bug 1344143 - Backing out changeset e07ec12de6c0 (Bug 1200494).

Backout changes to avoid breaking download manager. Aurora54+.

Comment 11

[Carsten Book [:Tomcat]]

uplifted
https://hg.mozilla.org/releases/mozilla-aurora/rev/265959d1dd7c