Improvements for the modern theme

RESOLVED EXPIRED

Status

--
trivial
RESOLVED EXPIRED
17 years ago
9 years ago

People

(Reporter: rene.rheaume, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(12 attachments, 1 obsolete attachment)

(Reporter)

Description

17 years ago
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; fr-FR; rv:0.9.9+)
Gecko/20020327
BuildID:    2002032708

I file this bug only to submit some improvements on the Modern theme.

Improvements:
- changed menu command height for menu commands that have a bookmark-folder,
bookmark-item, check or radio icon beside them so their height match better with
the menu command that do not have any of these icons;
- anti-aliased menu checkbox and radio button icons;
- changed message box icon size to 39px*39px, so the JS console icon/text
alignment is corrected (BACKUP YOUR FILES);
- removed odd color at the bottom of the statusbar progressmeter;
- changed top border color of the status bar so it gives a better 3D effect;
- optimized some GIF images. Unfortunaletely, the size gain is not great deal.

I attach Unidiff patches for CSS files, a GZipped TAR archive for the GIF images
(same directory structure as modern.jar) and PNG format screenshots.

Reproducible: Didn't try
Steps to Reproduce:
(Reporter)

Comment 1

17 years ago
Created attachment 76883 [details] [diff] [review]
patch for skin\modern\communicator\bookmarks\bookmarksToolbar.css

directory skin\modern\communicator\bookmarks\ of modern.jar
(Reporter)

Comment 2

17 years ago
Created attachment 76884 [details] [diff] [review]
patch for global.css

directory skin\modern\global of modern.jar
(Reporter)

Comment 3

17 years ago
Created attachment 76885 [details] [diff] [review]
patch for menu.css

directory skin\modern\global of modern.jar
(Reporter)

Comment 4

17 years ago
Created attachment 76886 [details] [diff] [review]
patch for navigator.css

directory skin\modern\navigator of modern.jar
(Reporter)

Comment 5

17 years ago
Created attachment 76887 [details] [diff] [review]
patch for progressmeter.css

directory skin\modern\global of modern.jar
(Reporter)

Comment 6

17 years ago
Created attachment 76888 [details]
GIF images

uses the same directory structure as modern.jar
(Reporter)

Comment 7

17 years ago
Created attachment 76889 [details]
Screenshot : bookmarks before patch
(Reporter)

Comment 8

17 years ago
Created attachment 76890 [details]
Screenshot : menus before patch
(Reporter)

Comment 9

17 years ago
Created attachment 76891 [details]
Screenshot : bookmarks after patch
(Reporter)

Comment 10

17 years ago
Created attachment 76892 [details]
Screenshot : menus after patch
(Reporter)

Comment 11

17 years ago
Created attachment 76893 [details] [diff] [review]
new patch for menu.css

directory skin\modern\global of modern.jar
Do not apply on a mwnu.css patched with the older patch, apply it to original
2002032708 version of menu.css
Please make attachment 76885 [details] [diff] [review] obsolete.
(Reporter)

Comment 12

17 years ago
Attachement 76892 caoption should be "Screenshot : menus after patch"
(Reporter)

Comment 13

17 years ago
Created attachment 76894 [details]
Old message box icons for backup purposes

direcotry skin\modern\global\icons of modern.jar

Updated

17 years ago
Attachment #76885 - Attachment is obsolete: true

Updated

17 years ago
Attachment #76892 - Attachment description: Screenshot : bookmarks after patch → Screenshot : menus after patch

Updated

17 years ago
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows 2000 → All
Hardware: PC → All

Comment 14

17 years ago
Can anybody tell me why we need blurry checkmarks?
(Reporter)

Comment 15

17 years ago
Created attachment 76945 [details]
sharper checkmark

directory skin\modern\global\menu of modern.jar

Comment 16

17 years ago
Shouldn't changes to themes, if they're not coming directly from mozilla.org, be
discussed first (newsgroups, mozillazine forums etc.)? Just think if everybody
went off on a wild tangent, offering "improvements" to modern?

Not bashing your stuff, René. Just more of a general question...
(Assignee)

Updated

11 years ago
Product: Core → SeaMonkey
Assignee: hewitt → nobody
QA Contact: pmac → themes

Comment 17

10 years ago
MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614
Status: NEW → UNCONFIRMED

Comment 18

9 years ago
MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but still has no comment since the inception of the SeaMonkey project 5 years ago.

Because of this, we're resolving the bug as EXPIRED.

If you still can reproduce the bug on SeaMonkey 2 or otherwise think it's still valid, please REOPEN it and if it is a platform or toolkit issue, move it to the according component.

Query tag for this change: EXPIRED-20100420
Status: UNCONFIRMED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → EXPIRED
You need to log in before you can comment on or make changes to this bug.