Closed
Bug 1344195
Opened 7 years ago
Closed 7 years ago
CloneOldBaselineStub should not clone the stub if we didn't recompile the script
Categories
(Core :: JavaScript Engine: JIT, enhancement)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(1 file)
1.23 KB,
patch
|
shu
:
review+
|
Details | Diff | Splinter Review |
Bug 1328140 is adding asserts to check we don't attach too many IC stubs and I got some test failures because BaselineDebugModeOSR sometimes clones stubs even when we didn't recompile the BaselineScript.
Attachment #8843278 -
Flags: review?(shu)
Comment 1•7 years ago
|
||
Comment on attachment 8843278 [details] [diff] [review] Patch Review of attachment 8843278 [details] [diff] [review]: ----------------------------------------------------------------- Oops, good catch, thanks.
Attachment #8843278 -
Flags: review?(shu) → review+
Pushed by jandemooij@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/63d05802b98a Fix CloneOldBaselineStub to not clone the stub if we didn't recompile the script. r=shu
Comment 3•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/63d05802b98a
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•