1344200 - funnelcake change applied to all late 51.0 beta builds

Status: RESOLVED WONTFIX

(Firefox :: General, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Bug 1322723 implemented the preference browser.shell.skipDefaultBrowserCheckOnFirstRun so the funnel can show the default browser prompt on the second launch like Nightly and Developer Edition do. By default, it's false and Firefox will prompt on the first launch (unless you hit bug 1343938).

For Firefox 51.0b12 and b14 (haven't tested b13) in non-stub builds downloaded from https://ftp.mozilla.org/pub/firefox/releases/51.0b12/win32/en-US/ or https://ftp.mozilla.org/pub/firefox/releases/51.0b14/win32/en-US/ , the preference value is true:
> pref("browser.shell.skipDefaultBrowserCheckOnFirstRun", true);

The code would generate a value of false:
https://hg.mozilla.org/releases/mozilla-beta/file/9ddd4fee0784/browser/app/profile/firefox.js#l215

So this seems to have been overridden by the funnel test.

There is a problem here:
a) Either the funnel settings got applied to the default builds
b) or the whole beta was part of the funnel. According to other source code, funnelcakes should have a distribution.id preference set:
https://dxr.mozilla.org/mozilla-beta/rev/25ee9d2ee428d3cc16ba425ad2dd74496cf1d7a6/toolkit/components/search/nsSearchService.js#380
But e.g. 51.0b12 doesn't have a distribution.id preference.

In case the whole late betas where part of the funnel and the distribution.id had been omitted for that reason: How can a developer check that a build has changes applied which are not in hg.mozilla.org/dxr.mozilla.org and where can they download builds where the binary matches the source?

Comment 1

[:Gijs (he/him)]

Funnelcake builds are repacks of the original builds. Nothing gets committed for them. In this case, the only difference would have been a distribution.ini file in the distribution folder.

(In reply to Sebastian Hengst [:aryx][:archaeopteryx] (needinfo on intermittent or backout) from comment #0)
> For Firefox 51.0b12 and b14 (haven't tested b13) in non-stub builds
> downloaded from
> https://ftp.mozilla.org/pub/firefox/releases/51.0b12/win32/en-US/ or
> https://ftp.mozilla.org/pub/firefox/releases/51.0b14/win32/en-US/ , the
> preference value is true:
> > pref("browser.shell.skipDefaultBrowserCheckOnFirstRun", true);
> 
> The code would generate a value of false:
> https://hg.mozilla.org/releases/mozilla-beta/file/9ddd4fee0784/browser/app/
> profile/firefox.js#l215

Where are you checking the value? In about:config or in the file? What did the source file look like at the beta build tags for these releases?

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Mystery solved: Bug 1322723 uses |ifdef RELEASE_OR_BETA| for the beta checkin (Gecko 51) but this landed for Gecko 52 in bug 1304829. So the undefined RELEASE_OR_BETA from bug 1322723 evaluated to false and the pref browser.shell.skipDefaultBrowserCheckOnFirstRun got set to true.

Comment 3

[:Gijs (he/him)]

(In reply to Sebastian Hengst [:aryx][:archaeopteryx] (needinfo on intermittent or backout) from comment #2)
> Mystery solved: Bug 1322723 uses |ifdef RELEASE_OR_BETA| for the beta
> checkin (Gecko 51) but this landed for Gecko 52 in bug 1304829. So the
> undefined RELEASE_OR_BETA from bug 1322723 evaluated to false and the pref
> browser.shell.skipDefaultBrowserCheckOnFirstRun got set to true.

So, was that pref set to true for 51 general release?

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Yes, browser.shell.skipDefaultBrowserCheckOnFirstRun was true for the general release (checked with 51.0.1). For new Firefox users on Windows (at least on 8+), the prompt didn't show up at all: bug 1343938.