1344223 - unchecked result of mktemp before passing to fdopen

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[Randell Jesup [:jesup] (needinfo me)]

Long-standing minor bug

** CID 1307869:  Error handling issues  (NEGATIVE_RETURNS)
/xpcom/build/LateWriteChecks.cpp: 161 in LateWriteObserver::Observe(mozilla::IOInterposeObserver::Observation &)()


________________________________________________________________________________________________________
*** CID 1307869:  Error handling issues  (NEGATIVE_RETURNS)
/xpcom/build/LateWriteChecks.cpp: 161 in LateWriteObserver::Observe(mozilla::IOInterposeObserver::Observation &)()
155         MOZ_CRASH("Um, how did we get here?");
156       }
157     
158       stream = _fdopen(fd, "w");
159     #else
160       int fd = mkstemp(name);
>>>     CID 1307869:  Error handling issues  (NEGATIVE_RETURNS)
>>>     "fd" is passed to a parameter that cannot be negative.
161       stream = fdopen(fd, "w");
162     #endif
163     
164       SHA1Stream sha1Stream(stream);
165     
166       size_t numModules = stack.GetNumModules();

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: error-check mkstemp()

MozReview-Commit-ID: 1z3cQXioTXP

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8843326 [details] [diff] [review]
error-check mkstemp()

Review of attachment 8843326 [details] [diff] [review]:
-----------------------------------------------------------------

I guess this is consistent with the Windows code, but it seems like we should just return in both cases if we can't get a temp file.  Anyway, r=me.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/acf2c7b496d5
error-check mkstemp() r=froyd

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/acf2c7b496d5