Closed
Bug 1344245
Opened 7 years ago
Closed 7 years ago
Port Bug 1339892 to c-c [Refactor mozIntl to have a nicer API and thin logic]
Categories
(Thunderbird :: Installer, enhancement)
Thunderbird
Installer
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 54.0
People
(Reporter: frg, Assigned: frg)
Details
Attachments
(1 file)
2.54 KB,
patch
|
jorgk-bmo
:
review+
clokep
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1343188 +++ C-C needs to port the installer changes.
Assignee | ||
Updated•7 years ago
|
Summary: Port Bug 1339892 to c-c [Refactor mozIntl to have a nicer API and thin logic} → Port Bug 1339892 to c-c [Refactor mozIntl to have a nicer API and thin logic]
Assignee | ||
Comment 1•7 years ago
|
||
Not seeing a reason to put this in a separate block as in browser\installer\package-manifest.in. If you disagree I just change it.
Attachment #8843330 -
Flags: review?(jorgk)
Attachment #8843330 -
Flags: review?(clokep)
Comment 2•7 years ago
|
||
Comment on attachment 8843330 [details] [diff] [review] 1344245-mozintl.patch Review of attachment 8843330 [details] [diff] [review]: ----------------------------------------------------------------- Nice.
Attachment #8843330 -
Flags: review?(jorgk) → review+
Comment 3•7 years ago
|
||
Comment on attachment 8843330 [details] [diff] [review] 1344245-mozintl.patch Review of attachment 8843330 [details] [diff] [review]: ----------------------------------------------------------------- LGTM.
Attachment #8843330 -
Flags: review?(clokep) → review+
Comment 4•7 years ago
|
||
https://hg.mozilla.org/comm-central/rev/ea1e52084df0c3fe832fe46ac36e8649f627c6d3 Needed this to fix test failure: TEST-UNEXPECTED-FAIL | toolkit/components/mozintl/test/test_mozintl.js | xpcshell return code: 0 TypeError: Components.classes['@mozilla.org/mozintl;1'] is undefined at C:/slave/test/build/tests/xpcshell/tests/toolkit/components/mozintl/test/test_mozintl.js:5
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 54.0
You need to log in
before you can comment on or make changes to this bug.
Description
•