Closed Bug 1344281 Opened 6 years ago Closed 6 years ago

Don't require config.status unless paths or tags are passed to |./mach try|

Categories

(Firefox Build System :: General, enhancement)

Product:
Firefox Build System
Component:
General
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox54 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla54
Tracking Flags:
Tracking Status
firefox54 --- fixed

People

(Reporter: chmanchester, Assigned: chmanchester)

References

Details

Attachments

(1 file)

Bug 1344281 - Don't accidentally require config.status when running |./mach try|.
59 bytes, text/x-review-board-request
nalexander
: review+
Details 
We're inadvertently requiring it through `substs` since bug 1315032.
Comment on attachment 8843407 [details]
Bug 1344281 - Don't accidentally require config.status when running |./mach try|.

https://reviewboard.mozilla.org/r/117178/#review118808

Tricky interaction.  Good catch.
Attachment #8843407 - Flags: review?(nalexander) → review+
Comment on attachment 8843407 [details]
Bug 1344281 - Don't accidentally require config.status when running |./mach try|.

https://reviewboard.mozilla.org/r/117178/#review118808

Thank you for the speedy review.
Pushed by cmanchester@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2a8e33a5f238
Don't accidentally require config.status when running |./mach try|. r=nalexander
https://hg.mozilla.org/mozilla-central/rev/2a8e33a5f238
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.