Don't require config.status unless paths or tags are passed to |./mach try|

RESOLVED FIXED in Firefox 54

Status

enhancement
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: cmanchester, Assigned: cmanchester)

Tracking

unspecified
mozilla54
Dependency tree / graph

Firefox Tracking Flags

(firefox54 fixed)

Details

Attachments

(1 attachment)

We're inadvertently requiring it through `substs` since bug 1315032.
Comment on attachment 8843407 [details]
Bug 1344281 - Don't accidentally require config.status when running |./mach try|.

https://reviewboard.mozilla.org/r/117178/#review118808

Tricky interaction.  Good catch.
Attachment #8843407 - Flags: review?(nalexander) → review+
Comment on attachment 8843407 [details]
Bug 1344281 - Don't accidentally require config.status when running |./mach try|.

https://reviewboard.mozilla.org/r/117178/#review118808

Thank you for the speedy review.
Pushed by cmanchester@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2a8e33a5f238
Don't accidentally require config.status when running |./mach try|. r=nalexander
https://hg.mozilla.org/mozilla-central/rev/2a8e33a5f238
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.