Closed
Bug 1344294
Opened 7 years ago
Closed 7 years ago
Update Frontend (3/3/2017)
Categories
(DevTools :: Debugger, enhancement, P3)
DevTools
Debugger
Tracking
(firefox54 fixed)
RESOLVED
FIXED
Firefox 54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: jlast, Assigned: jlast)
References
Details
Attachments
(1 file, 3 obsolete files)
3.08 MB,
patch
|
jlast
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → jlaster
Priority: -- → P3
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8843380 -
Flags: review?(gtatum)
Assignee | ||
Comment 2•7 years ago
|
||
Attachment #8843380 -
Attachment is obsolete: true
Attachment #8843380 -
Flags: review?(gtatum)
Attachment #8843486 -
Flags: review?(gtatum)
Assignee | ||
Comment 3•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6e34f192a4c7a0dcf2c543f27b76643f1890cfe8
Comment 4•7 years ago
|
||
Comment on attachment 8843380 [details] [diff] [review] bundle3-3.patch Review of attachment 8843380 [details] [diff] [review]: ----------------------------------------------------------------- I did manual testing on a built version of the patch, and looked over the non-bundled files. Everything seems reasonable for a bundled landing. R+ with a clean try run.
Attachment #8843380 -
Flags: review+
Assignee | ||
Comment 5•7 years ago
|
||
Attachment #8843486 -
Attachment is obsolete: true
Attachment #8843486 -
Flags: review?(gtatum)
Attachment #8843496 -
Flags: review?(gtatum)
Assignee | ||
Comment 6•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ae85fbf23d8c765920cd46ed34be5e4f465f2c33&selectedJob=81585100
Assignee | ||
Comment 7•7 years ago
|
||
Attachment #8843496 -
Attachment is obsolete: true
Attachment #8843496 -
Flags: review?(gtatum)
Attachment #8843534 -
Flags: review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/1f2df690050b Bump Debugger 3/3/2017. r=gtatum
Keywords: checkin-needed
Comment 9•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1f2df690050b
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Depends on: 1344821
Comment 10•7 years ago
|
||
Comment on attachment 8843534 [details] [diff] [review] bundle3-3-3.patch Review of attachment 8843534 [details] [diff] [review]: ----------------------------------------------------------------- ::: devtools/client/debugger/new/index.html @@ +16,5 @@ > <link rel="stylesheet" type="text/css" href="resource://devtools/client/debugger/new/debugger.css" /> > </head> > <body> > <div id="mount"></div> > + <script type="application/javascript;version=1.8" Why did you add a version parameter back? We should not use versioned JavaScript anymore (see bug 1342144 for details).
Assignee | ||
Comment 12•7 years ago
|
||
Sorry, that's being tracked here - http://github.com/devtools-html/debugger.html which i can remove
Flags: needinfo?(jlaster)
Comment 13•7 years ago
|
||
Thanks. Filed a GitHub issue: https://github.com/devtools-html/debugger.html/issues/2772
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•