Regression "Highlight all" in findbar doesn't highlight any matches sometimes

ASSIGNED
Assigned to

Status

()

Toolkit
Find Toolbar
ASSIGNED
a year ago
7 months ago

People

(Reporter: 684sigma, Assigned: mikedeboer)

Tracking

({regression})

51 Branch
regression
Points:
---

Firefox Tracking Flags

(firefox51 wontfix, firefox52 wontfix, firefox53 wontfix, firefox54 fix-optional, firefox55 wontfix, firefox56 wontfix, firefox57 fix-optional)

Details

(Reporter)

Description

a year ago
I have a problem with Firefox Beta 52. It doesn't happen in Firefox 51
Sometimes "Highlight all" function in findbar doesn't work.
It happens unpredictably, however, I noticed one specific scenario when it happens

1. Open http://example.org/ in a new tab
2. Open findbar, type "domain", enable "Highlight all", disable "Highlight all"
3. Open http://example.org/ in a new tab
4. Open findbar, enable "Highlight all"

Result: no matches highlighted

Expected: all 3 matches highlighted
(Reporter)

Comment 1

a year ago
There's a mistake, it seems. Corrected scenario (I tested this) :

1. Open http://example.org/ in a new tab
2. Open findbar, type "domain", enable "Highlight all", disable "Highlight all"
3. Open http://example.org/ in a new tab
4. Open findbar, type "domain", enable "Highlight all"

1. Open http://example.org/ in a new tab
2. Open findbar, type "domain", enable "Highlight all", disable "Highlight all"
3. Open http://example.org/ in a new tab
4. Open findbar, enable "Highlight all", disable "Highlight all", enable "Highlight all"

I tested these 2 on Firefox 51, and it was OK. However, when I tried scenario from first comment, it was not completely OK. I think all mentioned scenarios were broken quite recently, I don't remember this bug on earlier versions of Firefox.

Comment 2

a year ago
In FF54, the behaviour is a little bit different, after enabling "Highlight all" a 2nd time, instances of the keyword are not highlighted anymore.
Status: UNCONFIRMED → NEW
status-firefox51: --- → affected
status-firefox52: --- → affected
status-firefox53: --- → affected
status-firefox54: --- → affected
Component: Untriaged → Find Toolbar
Ever confirmed: true
Keywords: regression
OS: Unspecified → All
Product: Firefox → Toolkit
Hardware: Unspecified → All
(Reporter)

Comment 3

a year ago
I checked Firefox ESR 45, there're NO issues at all. Is there a chance that this bug will be fixed on Firefox ESR 52?

Comment 4

a year ago
It's probably not fixed because the find toolbar has been revamped since a few versions.
I've also noticed strange behavior of "Highlight all" in nightly. 

1. Make sure "Highlight all" is enabled.
2. Search text
3. Everything is highlighted properly.
4. Disable "Highlight all"
5. Only current match is selected. But WITHOUT styling. Background dim and orange highlight is gone and we have normal blue highlight.
6. Things goes back to normal if we search again or move to next match.
7. But only if we change search text "Highlight all" can be enabled again, otherwise button doesn't do much. 


In short it is a little bit messy and hard to describe. But I'm sure if someone want to work on it it will be easy to reproduce for him :)
Too late for 51 and 52 will be released this week. Mark 51 won't fix.
status-firefox51: affected → wontfix
Mike, can you take a look at this?  A regression that has stuck around for a couple of releases seems like a good candidate to fix.
status-firefox55: --- → affected
status-firefox-esr45: --- → affected
Flags: needinfo?(mdeboer)
(Reporter)

Comment 8

a year ago
See comment 3, it says "checked Firefox ESR 45, there're NO issues at all". (My) issues appeared in later versions.
Bug status so far:

firefox beta 52     -  affected  (all scenarios broken)
firefox release 51  -  affected  (1 of 3 scenarios are broken)
firefox esr 45      -  unaffected
status-firefox-esr45: affected → ---
(Assignee)

Comment 9

a year ago
OK, I'll take a look at this ASAP.
Assignee: nobody → mdeboer
Status: NEW → ASSIGNED
Flags: needinfo?(mdeboer)
Mass wontfix for bugs affecting firefox 52.
status-firefox52: affected → wontfix
Too late for a fix for 53, fix-optional for 54, minor carryover regression.
status-firefox53: affected → wontfix
status-firefox54: affected → fix-optional
status-firefox55: affected → wontfix
status-firefox56: --- → wontfix
status-firefox57: --- → fix-optional
You need to log in before you can comment on or make changes to this bug.