Closed
Bug 1344372
Opened 7 years ago
Closed 7 years ago
Add override for RemotePageManager in AboutNewTab.jsm
Categories
(Firefox Graveyard :: Activity Streams: General, enhancement)
Firefox Graveyard
Activity Streams: General
Tracking
(firefox55 fixed)
RESOLVED
FIXED
Firefox 55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: k88hudson, Assigned: k88hudson)
Details
Attachments
(1 file)
Because we will need to add our own listeners / logic for handling messages from the new tab in Activity Stream, we will need to instantiate our own RemotePageManager or override the existing one.
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → khudson
|
|
Assignee | |
Updated•7 years ago
|
Summary: Add ability to customize RemotePageManager for AboutNewTab if Activity Stream is enabled → Add override for RemotePageManager in AboutNewTab.jsm
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8844587 [details] Bug 1344372: Add override for RemotePageManager in AboutNewTab.jsm; https://reviewboard.mozilla.org/r/117974/#review119734 Looks good to me, assuming the newtab tests pass locally for you. Thanks k88hudson!
Attachment #8844587 -
Flags: review?(mconley) → review+
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7179fbe1f4fd Add override for RemotePageManager in AboutNewTab.jsm;r=mconley
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/7179fbe1f4fd
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
|
||
Updated•3 months ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•