1344372 - Add override for RemotePageManager in AboutNewTab.jsm

Status: RESOLVED FIXED

(Firefox Graveyard :: Activity Streams: General, enhancement)

Description

[Kate Hudson :k88hudson]

Because we will need to add our own listeners / logic for handling messages from the new tab in Activity Stream, we will need to instantiate our own RemotePageManager or override the existing one.

Comment 1

[Kate Hudson :k88hudson]

Attachment: Bug 1344372: Add override for RemotePageManager in AboutNewTab.jsm;

Review commit: https://reviewboard.mozilla.org/r/117974/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/117974/

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8844587 [details]
Bug 1344372: Add override for RemotePageManager in AboutNewTab.jsm;

https://reviewboard.mozilla.org/r/117974/#review119734

Looks good to me, assuming the newtab tests pass locally for you. Thanks k88hudson!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7179fbe1f4fd
Add override for RemotePageManager in AboutNewTab.jsm;r=mconley

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7179fbe1f4fd