The default bug view has changed. See this FAQ.

Add override for RemotePageManager in AboutNewTab.jsm

RESOLVED FIXED in Firefox 55

Status

()

Firefox
Activity Streams: General
RESOLVED FIXED
23 days ago
18 days ago

People

(Reporter: k88hudson, Assigned: k88hudson)

Tracking

unspecified
Firefox 55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

23 days ago
Because we will need to add our own listeners / logic for handling messages from the new tab in Activity Stream, we will need to instantiate our own RemotePageManager or override the existing one.
(Assignee)

Updated

20 days ago
Assignee: nobody → khudson
(Assignee)

Updated

19 days ago
Summary: Add ability to customize RemotePageManager for AboutNewTab if Activity Stream is enabled → Add override for RemotePageManager in AboutNewTab.jsm
Comment hidden (mozreview-request)
Comment on attachment 8844587 [details]
Bug 1344372: Add override for RemotePageManager in AboutNewTab.jsm;

https://reviewboard.mozilla.org/r/117974/#review119734

Looks good to me, assuming the newtab tests pass locally for you. Thanks k88hudson!
Attachment #8844587 - Flags: review?(mconley) → review+

Comment 3

19 days ago
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7179fbe1f4fd
Add override for RemotePageManager in AboutNewTab.jsm;r=mconley

Comment 4

18 days ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7179fbe1f4fd
Status: NEW → RESOLVED
Last Resolved: 18 days ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.