[webvr] Add StageParameters for Oculus

RESOLVED FIXED in Firefox 55

Status

()

Core
WebVR
RESOLVED FIXED
9 months ago
8 months ago

People

(Reporter: kip, Assigned: kip)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

9 months ago
When we first implemented Oculus HMD support, roomscale was not yet supported, so we return null for VRDisplay.stageParameters.

We have since updated to the newer Oculus SDK and should implement stageparameters to report the Oculus guardian system parameters.
(Assignee)

Updated

9 months ago
Assignee: nobody → kgilbert
(Assignee)

Updated

9 months ago
Component: Graphics → WebVR
Comment hidden (mozreview-request)
(Assignee)

Updated

8 months ago
Attachment #8848667 - Flags: review?(dmu)

Comment 2

8 months ago
mozreview-review
Comment on attachment 8848667 [details]
Bug 1344393 - Add StageParameters for Oculus

https://reviewboard.mozilla.org/r/121572/#review123772

r=me after fixing some nits. Good job!

::: gfx/vr/gfxVROculus.h:89
(Diff revision 1)
>    RefPtr<ID3D11Buffer> mVertexBuffer;
>    RefPtr<ID3D11InputLayout> mInputLayout;
>  
>    bool mIsPresenting;
> +  float mEyeHeight;
>    

Please remove this redundant space

::: gfx/vr/ovr_capi_dynamic.h:578
(Diff revision 1)
> +  // Play area - safe rectangular area inside outer boundary which can optionally be used to restrict user interactions and motion.
> +  ovrBoundary_PlayArea = 0x0100,
> +} ovrBoundaryType;
> +
>  typedef ovrBool(OVR_PFN* pfn_ovr_GetBool)(ovrSession session, const char* propertyName, ovrBool defaultVal);
>  typedef ovrBool(OVR_PFN* pfn_ovr_SetBool)(ovrSession session, const char* propertyName, ovrBool value); 

Please remove the redundant space

::: gfx/vr/ovr_capi_dynamic.h:593
(Diff revision 1)
>    const char* defaultVal);
>  typedef ovrBool (OVR_PFN* pfn_ovr_SetString)(ovrSession session, const char* propertyName,
>    const char* value);
> +typedef ovrResult (OVR_PFN* pfn_ovr_GetBoundaryDimensions)(ovrSession session,
> +                                                           ovrBoundaryType boundaryType,
> +                                                           ovrVector3f* outDimensions);   

Redundant space

::: gfx/vr/ovr_capi_dynamic.h:728
(Diff revision 1)
>  	unsigned int* out_TexId);
>  
> +#define OVR_KEY_EYE_HEIGHT "EyeHeight" // float meters
> +#define OVR_DEFAULT_EYE_HEIGHT 1.675f
> +
>  #ifdef __cplusplus 

redundant space
Attachment #8848667 - Flags: review?(dmu) → review+
Comment hidden (mozreview-request)

Comment 4

8 months ago
Pushed by kgilbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/56dcf92f974c
Add StageParameters for Oculus r=daoshengmu

Comment 5

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/56dcf92f974c
Status: NEW → RESOLVED
Last Resolved: 8 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.