1344433 - Cleanup gfx/gl library loading

Status: RESOLVED FIXED

(Core :: Graphics, enhancement)

Comment 1

[Kelsey Gilbert [:jgilbert] (returns Nov01)]

Attachment: Bug 1344433 - Remove HasDXInterop(), but not HasDXInterop2(). -

Review commit: https://reviewboard.mozilla.org/r/117258/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/117258/

Comment 2

[Kelsey Gilbert [:jgilbert] (returns Nov01)]

Attachment: Bug 1344433 - Require GLX 1.4 (released 2005) -

Review commit: https://reviewboard.mozilla.org/r/117260/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/117260/

Comment 3

[Kelsey Gilbert [:jgilbert] (returns Nov01)]

Attachment: Bug 1344433 - Reformat. -

Review commit: https://reviewboard.mozilla.org/r/117262/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/117262/

Comment 4

[Kelsey Gilbert [:jgilbert] (returns Nov01)]

Attachment: Bug 1344433 - Use WRAP() macros. -

Review commit: https://reviewboard.mozilla.org/r/117264/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/117264/

Comment 5

[Kelsey Gilbert [:jgilbert] (returns Nov01)]

Attachment: Bug 1344433 - Fix ANGLE symbol loading. -

Review commit: https://reviewboard.mozilla.org/r/117266/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/117266/

Comment 6

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8843624 [details]
Bug 1344433 - Remove HasDXInterop(), but not HasDXInterop2(). -

https://reviewboard.mozilla.org/r/117258/#review119044

Comment 7

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8843625 [details]
Bug 1344433 - Require GLX 1.4 (released 2005) -

https://reviewboard.mozilla.org/r/117260/#review119048

::: gfx/gl/GLContextProviderGLX.cpp:1320
(Diff revision 1)
>          return nullptr;
>      }
>  
>      // Handle slightly different signature between glXCreatePixmap and
>      // its pre-GLX-1.3 extension equivalent (though given the ABI, we
>      // might not need to).

You may need to modify the comments here if you wanna upgrade to support GLX 1.4 only.

Comment 8

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8843625 [details]
Bug 1344433 - Require GLX 1.4 (released 2005) -

https://reviewboard.mozilla.org/r/117260/#review119050

r=me for fixing the nits of the comments.

Comment 9

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8843626 [details]
Bug 1344433 - Reformat. -

https://reviewboard.mozilla.org/r/117262/#review119098

LGTM

Comment 10

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8843627 [details]
Bug 1344433 - Use WRAP() macros. -

https://reviewboard.mozilla.org/r/117264/#review119102

LGTM

Comment 11

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8843628 [details]
Bug 1344433 - Fix ANGLE symbol loading. -

https://reviewboard.mozilla.org/r/117266/#review119116

Comment 12

[Kelsey Gilbert [:jgilbert] (returns Nov01)]

Attachment: Bug 1344433 - Allow GLX 1.3+glXGetProcAddressARB. -

Review commit: https://reviewboard.mozilla.org/r/117694/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/117694/

Comment 13

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8844158 [details]
Bug 1344433 - Allow GLX 1.3+glXGetProcAddressARB. -

https://reviewboard.mozilla.org/r/117694/#review119392

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/96bb57eaa0e2
Remove HasDXInterop(), but not HasDXInterop2(). - r=daoshengmu
https://hg.mozilla.org/integration/mozilla-inbound/rev/5dd77a2bc068
Require GLX 1.4 (released 2005) - r=daoshengmu
https://hg.mozilla.org/integration/mozilla-inbound/rev/a2624aa679c1
Reformat. - r=daoshengmu
https://hg.mozilla.org/integration/mozilla-inbound/rev/b90bf52c69ea
Use WRAP() macros. - r=daoshengmu
https://hg.mozilla.org/integration/mozilla-inbound/rev/11ca2ac87fbd
Fix ANGLE symbol loading. - r=daoshengmu
https://hg.mozilla.org/integration/mozilla-inbound/rev/c726adc9b217
Allow GLX 1.3+glXGetProcAddressARB. - r=jrmuizel

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/96bb57eaa0e2
https://hg.mozilla.org/mozilla-central/rev/5dd77a2bc068
https://hg.mozilla.org/mozilla-central/rev/a2624aa679c1
https://hg.mozilla.org/mozilla-central/rev/b90bf52c69ea
https://hg.mozilla.org/mozilla-central/rev/11ca2ac87fbd
https://hg.mozilla.org/mozilla-central/rev/c726adc9b217