Closed Bug 1344470 Opened 3 years ago Closed 3 years ago

add BUG_COMPONENT to media/* files

Categories

(Core :: Audio/Video, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: jmaher, Assigned: jmaher)

References

Details

Attachments

(1 file, 1 obsolete file)

I would like to annotate the media/* directory moz.build files so we have clear mappings from source file -> bugzilla component.  Currently we have:
UNKNOWN
  media/ffvpx
  media/gmp-clearkey
  media/kiss_fft
  media/libav
  media/libcubeb
  media/libjpeg
  media/libmkv
  media/libnestegg
  media/libpng
  media/libsoundtouch
  media/libspeex_resampler
  media/libstagefright
  media/libyuv
  media/mtransport
  media/omx-plugin
  media/openmax_dl
  media/openmax_il
  media/pocketsphinx
  media/sphinxbase
  media/update-libjpeg.sh
  media/webrtc
Core :: Video/Audio
  media/libogg
  media/libopus
  media/libtheora
  media/libtremor
  media/libvorbis
  media/libvpx
  media/psshparser


I would like to figure out what other pieces belong where.  My attempts without really knowing these things would be:
  media/ffvpx ??
  media/gmp-clearkey (CORE::Audio/Video: GMP)
  media/kiss_fft ??
  media/libav (CORE: Audio/Video: Playback)
  media/libcubeb (CORE::Audio/Video: cubeb)
  media/libjpeg (CORE::ImageLib)
  media/libmkv (CORE: Audio/Video: Recording) ??
  media/libnestegg (CORE: Audio/Video: Playback)
  media/libpng (CORE::ImageLib)
  media/libsoundtouch (CORE: Audio/Video: Playback)
  media/libspeex_resampler (CORE: WebAudio)
  media/libstagefright (CORE: Audio/Video: Playback)
  media/libyuv (CORE:Graphics)
  media/mtransport (CORE:WebRTC: Networking)
  media/omx-plugin (CORE: Audio/Video: Playback)
  media/openmax_dl (CORE: Audio/Video: Playback)
  media/openmax_il (CORE: Audio/Video: Playback)
  media/pocketsphinx (CORE: WebSpeech)
  media/sphinxbase (CORE: WebSpeech)
  media/update-libjpeg.sh (CORE::ImageLib)
  media/webrtc/signaling (CORE:WebRTC: Signaling)
  media/webrtc/trunk (CORE:WebRTC)

:mreavy, could you confirm some of my assumptions and fill in some of my '??' unknowns?  Possibly we will need someone else to chime in as well.  If these have sub categories, I am fine going much more granular.
Flags: needinfo?(mreavy)
Joel, here is your second list, updated with the ?? replaced (or removed, in the case of libmkv, your guess was correct).

>   media/ffvpx (CORE: Audio/Video: Playback)
>   media/kiss_fft (CORE: WebAudio)
>   media/libav (CORE: WebAudio)
>   media/libcubeb (CORE::Audio/Video: cubeb)
>   media/libjpeg (CORE::ImageLib)
>   media/libmkv (CORE: Audio/Video: Recording)
>   media/libnestegg (CORE: Audio/Video: Playback)
>   media/libpng (CORE::ImageLib)
>   media/libsoundtouch (CORE: Audio/Video: Playback)
>   media/libspeex_resampler (CORE: WebAudio)
>   media/libstagefright (CORE: Audio/Video: Playback)
>   media/libyuv (CORE:Graphics)
>   media/mtransport (CORE:WebRTC: Networking)
>   media/omx-plugin (CORE: Audio/Video: Playback)
>   media/openmax_dl (CORE: Audio/Video: WebAudio)
>   media/openmax_il (CORE: Audio/Video: Playback)
>   media/pocketsphinx (CORE: WebSpeech)
>   media/sphinxbase (CORE: WebSpeech)
>   media/update-libjpeg.sh (CORE::ImageLib)
>   media/webrtc/signaling (CORE:WebRTC: Signaling)
>   media/webrtc/trunk (CORE:WebRTC)

Here is a diff between your list and the new list so it's easier to spot the changes:

-media/ffvpx ??
-media/gmp-clearkey (CORE::Audio/Video: GMP)
-media/kiss_fft ??
-media/libav (CORE: Audio/Video: Playback)
+media/ffvpx (CORE: Audio/Video: Playback)
+media/kiss_fft (CORE: WebAudio)
+media/libav (CORE: WebAudio)
 media/libcubeb (CORE::Audio/Video: cubeb)
 media/libjpeg (CORE::ImageLib)
-media/libmkv (CORE: Audio/Video: Recording) ??
+media/libmkv (CORE: Audio/Video: Recording)
 media/libnestegg (CORE: Audio/Video: Playback)
 media/libpng (CORE::ImageLib)
 media/libsoundtouch (CORE: Audio/Video: Playback)
 media/libspeex_resampler (CORE: WebAudio)
 media/libstagefright (CORE: Audio/Video: Playback)
 media/libyuv (CORE:Graphics)
 media/mtransport (CORE:WebRTC: Networking)
 media/omx-plugin (CORE: Audio/Video: Playback)
-media/openmax_dl (CORE: Audio/Video: Playback)
+media/openmax_dl (CORE: Audio/Video: WebAudio)
 media/openmax_il (CORE: Audio/Video: Playback)
 media/pocketsphinx (CORE: WebSpeech)
 media/sphinxbase (CORE: WebSpeech)
 media/update-libjpeg.sh (CORE::ImageLib)
 media/webrtc/signaling (CORE:WebRTC: Signaling)
 media/webrtc/trunk (CORE:WebRTC)
Flags: needinfo?(mreavy) → needinfo?(jmaher)
thanks :padenot, this is great information.  I see we are missing:
-media/gmp-clearkey (CORE::Audio/Video: GMP)

is my original assertion there correct?
Flags: needinfo?(jmaher)
Yes.
thanks for your help on this, here is what we have:

$ ./mach file-info bugzilla-component media/**
Core :: Audio/Video
  media/moz.build
Core :: Audio/Video: GMP
  media/gmp-clearkey
Core :: Audio/Video: Playback
  media/ffvpx
  media/libnestegg
  media/libsoundtouch
  media/libstagefright
  media/omx-plugin
  media/openmax_il
Core :: Audio/Video: Recording
  media/libmkv
Core :: Audio/Video: cubeb
  media/libcubeb
Core :: Graphics
  media/libyuv
Core :: ImageLib
  media/libjpeg
  media/libpng
  media/update-libjpeg.sh
Core :: Video/Audio
  media/libogg
  media/libopus
  media/libtheora
  media/libtremor
  media/libvorbis
  media/libvpx
  media/psshparser
Core :: Web Audio
  media/kiss_fft
  media/libav
  media/libspeex_resampler
  media/openmax_dl
Core :: Web Speech
  media/pocketsphinx
  media/sphinxbase
Core :: WebRTC
  media/webrtc
Core :: WebRTC: Networking
  media/mtransport
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Attachment #8844031 - Flags: review?(padenot)
Comment on attachment 8844031 [details] [diff] [review]
annotate media/* moz.build files with BUG_COMPONENT

Review of attachment 8844031 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. The first result is a bit strange:

Core :: Audio/Video
  media/moz.build

there is no media/moz.build file in the tree or in your patch. Where does it come from ? We can probably live with it, though.
Attachment #8844031 - Flags: review?(padenot) → review+
oh, good point, I need to 'hg add' that file- it was needed for a couple things- I have updated the patch, here is media/moz.build:
$ cat media/moz.build
# -*- Mode: python; indent-tabs-mode: nil; tab-width: 40 -*-
# vim: set filetype=python:
# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.

with Files("**"):
    BUG_COMPONENT = ("Core", "Audio/Video")

with Files("update-libjpeg.sh"):
    BUG_COMPONENT = ("Core", "ImageLib")

with Files("openmax_il/**"):
    BUG_COMPONENT = ("Core", "Audio/Video: Playback")

with Files("gmp-clearkey/**"):
    BUG_COMPONENT = ("Core", "Audio/Video: GMP")
Attachment #8844031 - Attachment is obsolete: true
Attachment #8844055 - Flags: review+
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/699eb94693d6
add BUG_COMPONENT to media/* files. r=padenot
https://hg.mozilla.org/mozilla-central/rev/699eb94693d6
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.