1344475 - Download times wrong (and dates "missing") form downloads view with ICU enabled

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: Download Manager, defect, P1)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

[Tracking Requested - why for this release]: Regression which can confuse users.

Latest Firefox for Android 54.0a1 on Android 6.0.1 (Sony Xperia Z3 Compact)

After a file has been downloaded, menu Tools > Downloads lists the downloads but with a wrong time. E.g. a download started and finished at 14:06 local time (UTC+1) gets listed with the time "00:36".

Will be "fixed" for release builds by bug 1343725 where ICU gets disabled (so will hit it again in the future when it gets re-enabled).

Last good: 20170207
First bad: 20170208
Changes: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=af8a2573d0f1e9cc6f2ba0ab67d7a702a197f177&tochange=3a95aa4246653a7863914ffec032897d13359fb0

Likely cause by enabling ICU on Android: bug 1215247

Comment 1

[Marcia Knous [:marcia]]

Tracking 54+ to keep this on the radar.

Comment 3

[Nathan Froyd [:froydnj]]

According to comment 0, bug 1343725 would fix this bug, but I also see bug 1343744, which sounds very similar, and was fixed about a month ago.  Wesley, has this already been addressed on the Fennec side for 54?

Comment 4

[Peter Chang[:pchang]]

Max, could you take a look about comment 3?

Comment 5

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

bug 1343725 looks like a meta and the dependent bug 1343744 was landed in 54.
That means 54(beta/release) should work properly regarding "download times".
Need QA to verify here.

Comment 6

[Ioana Chiorean]

Sorry for the delay here - Sorina will have a look at this.

Comment 7

[Sorina Florean [:sflorean]]

Tested with Asus ZenPad 8(Android 6.0.1) and Samsung Galaxy Note 4 (Android 5.0.1) on build: 53.0.2, 54.0b6 and couldn't reproduce this. The downloads are listed correctly regarding time. Here is a screenshot: https://i.imgur.com/onILq7k.png.

Comment 8

[Gerry Chang [:gchang]]

Per comment #7, mark 54 as won't fix.

Comment 9

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

(In reply to Sorina Florean [:sorina] from comment #7)
> Tested with Asus ZenPad 8(Android 6.0.1) and Samsung Galaxy Note 4 (Android
> 5.0.1) on build: 53.0.2, 54.0b6 and couldn't reproduce this. The downloads
> are listed correctly regarding time. Here is a screenshot:
> https://i.imgur.com/onILq7k.png.

we can RESOLVED WORKSFORME if this is no longer reproducible?

Comment 10

[Makoto Kato [:m_kato]]

(In reply to Wesley Huang [:wesley_huang] (EPM) (NI me) from comment #9)
> (In reply to Sorina Florean [:sorina] from comment #7)
> > Tested with Asus ZenPad 8(Android 6.0.1) and Samsung Galaxy Note 4 (Android
> > 5.0.1) on build: 53.0.2, 54.0b6 and couldn't reproduce this. The downloads
> > are listed correctly regarding time. Here is a screenshot:
> > https://i.imgur.com/onILq7k.png.
> 
> we can RESOLVED WORKSFORME if this is no longer reproducible?

Since Nightly channel turns on ICU even if Android/arm, so QA should test this on Nightly.

Comment 11

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

This is a P1 bug without an assignee. 

P1 are bugs which are being worked on for the current release cycle/iteration/sprint. 

If the bug is not assigned by Monday, 28 August, the bug's priority will be reset to '--'.

Comment 12

[Makoto Kato [:m_kato]]

I cannot reproduce 56 beta that is turned on ICU.  Could anyone still reproduce this?

Download time code is changed by bug 1354442, so this might be already fixed.

Comment 13

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Sounds like this can't be reproduced: reopen if incorrect.