1344504 - When event listener tooltip is already open, clicking on the next event listener doesn't display the tooltip

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P3)

Description

[Loic]

Attachment: testcase-event.html

STR:
1) Click on event listener 1
2) Click on event listener 2

Result: tooltip for event listener 2 is not displayed.

Reg range:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=249d57fa78a0522f63a5b1ed1fdda55f383156e0&tochange=f8bdceb55c9d191380176ab25e2385737bd9e1ab

Regressed by bug 1266450.

Comment 1

[Gerry Chang [:gchang]]

Too late for 51 and 52 will be released this week. Mark 51 won't fix.

Comment 2

[Julian Descottes [:jdescottes]]

By configuration, the event listener popup is consuming outside clicks, which is why clicks performed while the tooltip is opened are just closing the tooltip and not performing any additional action.

The event details tooltip instance is created by the markup view at http://searchfox.org/mozilla-central/rev/e844f7b79d6c14f45478dc9ea1d7f7f82f94fba6/devtools/client/inspector/markup/markup.js#169. We should simply try adding "consumeOutsideClicks: false" to the configuration of this tooltip.

We should add a mochitest to check this, based on the ones found in devtools/client/inspector/markup/test/browser_markup_events*

(marking as wontfix for 52, timeframe is too short)

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1344504 - do not catch click events closing the event tooltip;

Review commit: https://reviewboard.mozilla.org/r/120610/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/120610/

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1344504 - handle rejected promise when showing/hiding box model in markup view;

Review commit: https://reviewboard.mozilla.org/r/120640/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/120640/

Comment 5

[Julian Descottes [:jdescottes]]

Comment on attachment 8847697 [details]
Bug 1344504 - do not catch click events closing the event tooltip;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/120610/diff/1-2/

Comment 6

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8847712 [details]
Bug 1344504 - handle rejected promise when showing/hiding box model in markup view;

https://reviewboard.mozilla.org/r/120640/#review123422

Comment 7

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8847697 [details]
Bug 1344504 - do not catch click events closing the event tooltip;

https://reviewboard.mozilla.org/r/120610/#review123424

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d29aa1530b0d
handle rejected promise when showing/hiding box model in markup view;r=gl
https://hg.mozilla.org/integration/autoland/rev/916169e1e3ee
do not catch click events closing the event tooltip;r=gl

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d29aa1530b0d
https://hg.mozilla.org/mozilla-central/rev/916169e1e3ee

Comment 10

[684sigma]

I can't to add Bug 1349416 in the "See also" field, but it seems that it appeared after this bug was fixed.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Should we consider backporting this to Aurora/Beta? ESR52 doesn't seem worth it, though (unless you feel strongly to the contrary).

Comment 13

[Julian Descottes [:jdescottes]]

Given that this has apparently introduced a small regression (Bug 1349416) I wouldn't uplift for the time being.

Comment 14

[Liz Henry (:lizzard) (relman/hg->git project)]

Wontfix for 53, let's give some time to catch and fix any further regressions.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

(In reply to Julian Descottes [:jdescottes] from comment #13)
> Given that this has apparently introduced a small regression (Bug 1349416) I
> wouldn't uplift for the time being.

That bug is marked P3, so I assume it's not going to get any attention any time soon. Should we just wontfix this for 54 then?

Comment 16

[Julian Descottes [:jdescottes]]

Yes, marking as wontfix for 54.