Closed Bug 1344511 Opened 7 years ago Closed 7 years ago

POST field starting with "?" doesn't show properly


(DevTools :: Netmonitor, defect, P3)

54 Branch


(firefox55 verified)

Firefox 55
Tracking Status
firefox55 --- verified


(Reporter: edznux, Assigned: brennan.brisad)


(Keywords: good-first-bug, testcase, Whiteboard: [netmonitor-reserve])


(3 files, 1 obsolete file)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:54.0) Gecko/20100101 Firefox/54.0
Build ID: 20170303030202

Steps to reproduce:

I made a POST request with a field named "?test".

Step to reproduce :
Send an AJAX request (with JQuery for example) with a field starting with "?"
The server should support post request.

Simple test case here (and in attachment)
	Error in the network display tab
<script src=""></script>
	method: "POST",
	url: "/",
	data: "?ok=12"
}).done(function( msg ) {

Actual results:

The name displayed in the Network panel is actually "test" (missing "?" char)

Expected results:

The developer tool (Network panel) should have displayed the name "?test" in the "Params" sections
Component: Untriaged → Developer Tools: Netmonitor
Keywords: testcase
Has STR: --- → yes
Ever confirmed: true
The 'first' question mark is used as a separator, and is not part of the query string, see also:

So, what's the use case?

The following works as expected: 

I am seeing on arg 'ok' in the Params side panel

Do you mean the following: 

Flags: needinfo?(edznux)
You are testing with the "GET" method in your example.

Correct me if I'm wrong but POST request send the data in the body so it should not need a separator.
Flags: needinfo?(edznux)
Attached image IE11 vs Fx52.png
(In reply to edznux from comment #2)
> You are testing with the "GET" method in your example.
> Correct me if I'm wrong but POST request send the data in the body so it
> should not need a separator.

See the comment 3.
OK, I see it now, thanks for the explanation!

Flags: qe-verify+
Keywords: good-first-bug
Whiteboard: [netmonitor-reserve]
Hi, I'd like to work on this bug.
Excellent, assigned to you!

Assignee: nobody → brennan.brisad
Attached patch bug1344511.patch (obsolete) — Splinter Review
Attaching a patch for feedback.  I made a new test case but found later that I had to modify devtools/client/netmonitor/test/browser_net_complex-params.js also.  I think that modification is probably enough and that my test case is superfluous.  But I kept it in the patch for now and can remove it if you agree.

I also found a new bug when looking at the POST request which I filed here
Attachment #8850673 - Flags: feedback?(odvarko)
Comment on attachment 8850673 [details] [diff] [review]

Review of attachment 8850673 [details] [diff] [review]:

Thanks for the patch!

Looks good to me, just two things:

- Agree, I think the new test can be removed
- Please rebase on the new HEAD. We changed the directory structure a bit in bug 1350215

Attachment #8850673 - Flags: feedback?(odvarko) → feedback-
Comment on attachment 8850673 [details] [diff] [review]

Feedback is actually + ;-)

Attachment #8850673 - Flags: feedback- → feedback+
Comment on attachment 8852640 [details] [diff] [review]

Review of attachment 8852640 [details] [diff] [review]:

Thanks for working on this!

Attachment #8852640 - Flags: review?(odvarko) → review+
Pushed by
Do not remove leading '?' in form data shown in netmonitor. r=honza
Keywords: checkin-needed
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
I have reproduced this issue on Firefox nightly according to (2017-03-04)

Fixing bug is verified on Latest Firefox Nightly--- Build ID:(20170429030208),User Agent:Mozilla/5.0 (Windows NT 6.1; rv:55.0) Gecko/20100101 Firefox/55.0

Tested OS-- Windows7 32bit
Reproduced this issue on an Nightly build 54.0a1 from 2017-03-03.

This is also verified on 55 beta 3 (20170619141703) using Windows 10 x64, macOS 10.12.5 and Ubuntu 16.04 x64 LTS.
Flags: qe-verify+
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.