1344533 - Use nsContentUtils::GetContextForContent() to obtain nsPresContext* for OwningElementRef

Status: RESOLVED FIXED

(Core :: DOM: Animation, enhancement)

Description

[Hiroyuki Ikezoe (:hiro)]

I just realized that OwningElementRef has also GetPresContext(). We can replace it with nsContentUtils::GetContextForContent().

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1344533 - Replace OwningElementRef::GetRenderedPresContext with nsContentUtils::GetContextForContext().

Review commit: https://reviewboard.mozilla.org/r/117278/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/117278/

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8843678 [details]
Bug 1344533 - Replace OwningElementRef::GetRenderedPresContext with nsContentUtils::GetContextForContext().

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/117278/diff/1-2/

Comment 3

[Boris Chiou [:boris]]

Comment on attachment 8843678 [details]
Bug 1344533 - Replace OwningElementRef::GetRenderedPresContext with nsContentUtils::GetContextForContext().

https://reviewboard.mozilla.org/r/117278/#review119024

Comment 4

[Boris Chiou [:boris]]

Comment on attachment 8843678 [details]
Bug 1344533 - Replace OwningElementRef::GetRenderedPresContext with nsContentUtils::GetContextForContext().

https://reviewboard.mozilla.org/r/117278/#review119026

::: layout/style/moz.build
(Diff revision 2)
>      'StyleRule.h',
>  ]
>  
>  UNIFIED_SOURCES += [
>      'AnimationCollection.cpp',
> -    'AnimationCommon.cpp',

By the way, why do we need to remove this from Unified sources?

Comment 5

[Boris Chiou [:boris]]

Comment on attachment 8843678 [details]
Bug 1344533 - Replace OwningElementRef::GetRenderedPresContext with nsContentUtils::GetContextForContext().

https://reviewboard.mozilla.org/r/117278/#review119026

> By the way, why do we need to remove this from Unified sources?

Oh, We delete the cpp file. Thanks for making this simpler.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5f82f1249b3b
Replace OwningElementRef::GetRenderedPresContext with nsContentUtils::GetContextForContext(). r=boris

Comment 7

[Hiroyuki Ikezoe (:hiro)]

Yeah, I also initially misunderstood so. Where is the deleted diff? ;-)

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5f82f1249b3b