Closed
Bug 1344533
Opened 7 years ago
Closed 7 years ago
Use nsContentUtils::GetContextForContent() to obtain nsPresContext* for OwningElementRef
Categories
(Core :: DOM: Animation, enhancement)
Core
DOM: Animation
Tracking
()
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: hiro, Assigned: hiro)
References
Details
Attachments
(1 file)
I just realized that OwningElementRef has also GetPresContext(). We can replace it with nsContentUtils::GetContextForContent().
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Summary: Use Use nsContentUtils::GetContextForContent() to obtain nsPresContext* for OwningElementRef → Use nsContentUtils::GetContextForContent() to obtain nsPresContext* for OwningElementRef
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8843678 [details] Bug 1344533 - Replace OwningElementRef::GetRenderedPresContext with nsContentUtils::GetContextForContext(). https://reviewboard.mozilla.org/r/117278/#review119024
Attachment #8843678 -
Flags: review?(boris.chiou) → review+
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8843678 [details] Bug 1344533 - Replace OwningElementRef::GetRenderedPresContext with nsContentUtils::GetContextForContext(). https://reviewboard.mozilla.org/r/117278/#review119026 ::: layout/style/moz.build (Diff revision 2) > 'StyleRule.h', > ] > > UNIFIED_SOURCES += [ > 'AnimationCollection.cpp', > - 'AnimationCommon.cpp', By the way, why do we need to remove this from Unified sources?
Comment 5•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8843678 [details] Bug 1344533 - Replace OwningElementRef::GetRenderedPresContext with nsContentUtils::GetContextForContext(). https://reviewboard.mozilla.org/r/117278/#review119026 > By the way, why do we need to remove this from Unified sources? Oh, We delete the cpp file. Thanks for making this simpler.
Pushed by hikezoe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5f82f1249b3b Replace OwningElementRef::GetRenderedPresContext with nsContentUtils::GetContextForContext(). r=boris
Assignee | ||
Comment 7•7 years ago
|
||
Yeah, I also initially misunderstood so. Where is the deleted diff? ;-)
Comment 8•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5f82f1249b3b
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•