Status

()

P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: rnewman, Assigned: farhan)

Tracking

unspecified
All
iOS

Firefox Tracking Flags

(fxios-v7.0 fixed, fxios7.0+, fxios-v8.0 fixed)

Details

(Whiteboard: [MobileCore])

Attachments

(1 attachment)

55 bytes, text/x-github-pull-request
sleroux
: review+
Details | Review | Splinter Review
(Reporter)

Description

2 years ago
* Hit Cmd-T.
* See a tab shape appear in the tab bar.
* See the text and widgets appear.
* See focus switch to the new tab.
* See the grey globe favicon lighten.

This animation is way too slow, and multi-part.

Perhaps these things should all be in the same UI transaction?

See also Bug 1249855.
(Assignee)

Comment 1

2 years ago
It'll group animations after the first one. (If you spam new tab you'll see it in action) But the first animation starts before the next tab has been selected. So it does it in separate animations. I use the TabManager delegate methods to animate these changes and there is one for tab creation and another for selection. So the tab addition animation starts and while its animating the selection has to wait for it to finish before it can select. 

I'm going to wrap it in an animation block and speed it up considerably so it feels much snappier. If thats not good enough I can maybe try delaying animations slightly in order to allow a few animations to accumulate before firing. This might introduce some interesting crashes though.
Assignee: nobody → fpatel
Iteration: --- → 1.17
tracking-fxios: ? → 7.0+
Priority: -- → P1
Whiteboard: [MobileCore]
(Reporter)

Comment 2

2 years ago
I've also noticed that in rapid tab switches the favicon globe changes opacity before the tab itself -- if you hit left/right quick enough, you get one permanently bright tab, and the one next to it has a globe that flickers at the same rate that you're tapping keys!

Best to double-check that the icon selection is animated in the same block as the tab itself…
(Assignee)

Comment 3

2 years ago
Created attachment 8844679 [details] [review]
Pull Request
Attachment #8844679 - Flags: review?(bmunar)
(Assignee)

Updated

2 years ago
Attachment #8844679 - Flags: review?(bmunar) → review?(sleroux)
Comment on attachment 8844679 [details] [review]
Pull Request

Code looks good and runs well in the simulator. I'm unable to test this on a real device though :(
Attachment #8844679 - Flags: review?(sleroux) → review+
(Assignee)

Comment 5

2 years ago
master https://github.com/mozilla-mobile/firefox-ios/commit/32970bc87c87070bc5a6bca1f904e1e933c04455

So this is kind of fixed. The overall performance is better but opening a new tab is still not as snappy as it should be. I'll open a new bug for that. https://bugzilla.mozilla.org/show_bug.cgi?id=1345986
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
(Assignee)

Updated

2 years ago
Whiteboard: [MobileCore] → [MobileCore][needsuplift]
v7.x fcf445a4f6ca2b9a29c8a68500d5574a2446c96d
status-fxios-v7.0: --- → fixed
status-fxios-v8.0: --- → fixed
Whiteboard: [MobileCore][needsuplift] → [MobileCore]
You need to log in before you can comment on or make changes to this bug.