1344657 - Saved password not filled when unchecked "Remember passwords for sites"

Status: UNCONFIRMED

(Toolkit :: Password Manager, defect, P3)

Description

[61.1p57]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID: 20170125094131

Steps to reproduce:

1. Login to a site when "Remember passwords for sites" is checked. 
2. Follow the prompt to save the password.
3. Uncheck "Remember passwords for sites".
4. Logout the site and go back to the login page.


Actual results:

The saved password is not filled


Expected results:

The saved password should be filled.

(The similar option in Chrome only stops asking to save passwords in new sites, and the previous saved passwords will still be filled automatically)

Comment 1

[61.1p57]

Attachment: Bug 1344657 - Auto-fill existing passwords even 'Remember Logins' is disabled.

Review commit: https://reviewboard.mozilla.org/r/119554/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/119554/

Comment 2

[61.1p57]

Attachment: Bug 1344657 - Can't get dropdown lists work

Review commit: https://reviewboard.mozilla.org/r/119588/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/119588/

Comment 3

[Matthew N. [:MattN]]

Hi 61.1p57,

Sorry for not reviewing your patch yet. I haven't had time to dig into the history to understand when/why/if this behaviour changed. I thought we already had behaviour matching your expected result at one time. If you want to look into this it would save me time. You may be able to use mozregression[1] and test the earliest possible build there to see if it had the expected behaviour.

[1] http://mozilla.github.io/mozregression/

Comment 4

[61.1p57]

I tried following mozilla-central nightly build by mozregression, but none of them behaved as the expected results:
2016-11-25
2013-09-13
2013-07-20
2011-12-14 (lost response after open)

Also tried these release build, but still couldn't find a working one:
2016-04-26 (46.0)
2015-07-02 (39.0)
2014-11-01 (34.0)

Could you recall the last known good build so that I can test them in smaller steps?

Comment 5

[Matthew N. [:MattN]]

Oh, perhaps I misremembered. Thanks a lot for checking the old versions.

Ryan, what do you think about this proposal? Apparently the checkbox "Remember passwords for sites" affects capture and fill phases (but not existing storage).

Comment 6

[Matthew N. [:MattN]]

See comment 5

Comment 7

[Ryan Feeley [:rfeeley]]

Is the issue that the label is innaccurate?

Currently (in Nightly) it is: Remember logins and passwords for sites

Should it in fact be: Remember and fill logins and passwords for sites

(although is "for sites" superfluous?)

Comment 8

[Matthew N. [:MattN]]

Yeah, the label doesn't exactly match what happens nowadays. We could either change the label or change the behaviour.

Comment 9

[Jonathan Watt [:jwatt]]

Mass bug change to replace various 'parity' whiteboard flags with the new canonical keywords. (See bug 1443764 comment 13.)

Comment 12

[teknowledgist]

(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #8)

Yeah, the label doesn't exactly match what happens nowadays. We could either
change the label or change the behaviour.

Please change the behavior!

Ideally, there would be two options: The current "Ask to save logins and passwords for websites", and a new "Fill/Use saved login passwords for websites".

The asking to store passwords and the using stored passwords are independent actions and independent concepts. It can't be that hard to imagine that users may want some sites' logon credentials auto-filled, but not be annoyingly asked about everything else.

If a user stores a password but doesn't want to use it, they should delete it from the record.

Comment 13

[marwankhalili]

(In reply to teknowledgist from comment #12)

Ideally, there would be two options: The current "Ask to save logins and passwords for websites", and a new "Fill/Use saved login passwords for websites".

I agree that there should be two independent options. These two options actually exist already:

• Ask to save logins and passwords for websites checkbox, mentioned in this thread and is available in the Preferences
• Autofill logins and passwords checkbox, available in the Saved Logins dialog

Expected behavior for me is that if I check the autofill option, it should work even if I have disabled the other option.

Comment 14

[marwankhalili]

To clarify, the options exist but the autofill option is neglected if Ask to save logins and passwords for websites is unchecked.

Comment 15

[Matthew N. [:MattN]]

You are interpreting the options incorrectly… Autofill logins and passwords is about whether we automatically fill logins without the user doing anything (e.g. on page load). The first checkbox is incorrectly labeled as it its about saving and suggesting right now.

Comment 16

[marwankhalili]

Yeah, sorry for the confusion. I had overlooked the suggesting feature and was merely focused on the autofill functionality.

Perhaps the three features could be split into independent options (checkboxes). E.g.

• Ask to save logins and passwords for websites
• Suggest stored login credentials
• Autofill logins and passwords

Comment 19

[Kathleen Wilson]

My apologies if this bug is not the correct place to describe the problem that we run into with passwords in Firefox, but I'm hoping that when someone tackles updating this UX, they can consider the use case of elderly parents... My husband's elderly parents type in the wrong password and then click to save the password -- maybe because they figure that Firefox wouldn't ask them to save an incorrect password, or they just click to get rid of the popup. We have tried to teach them not to do this, but they don't remember. It would have helped if Firefox would only present the "save password" option after it was actually used successfully, but I don't know if that's possible. Perhaps it would have helped if the user interface made it clear that the new password might not be correct, and did not make it look like saving the password is the correct thing to do. I haven't looked into what other browsers do, but my husband just set his parents up with a different browser in hopes that they will stop having this problem. :-(

Comment 20

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is relatively low, S3. However, the bug has 4 duplicates.
:serg, could you consider increasing the bug severity?

For more information, please visit auto_nag documentation.

Comment 21

[BugBot (nomail) [:suhaib / :marco/ :calixte]]

The last needinfo from me was triggered in error by recent activity on the bug. I'm clearing the needinfo since this is a very old bug and I don't know if it's still relevant.