If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Crash Annotation GraphicsCriticalError: |[0][GFX1]: Unknown image format 1

UNCONFIRMED
Unassigned

Status

()

Core
Graphics
P3
normal
UNCONFIRMED
7 months ago
2 months ago

People

(Reporter: Petr Sumbera, Unassigned)

Tracking

52 Branch
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [gfx-noted])

Attachments

(2 attachments)

(Reporter)

Description

7 months ago
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID: 20170125094131

Steps to reproduce:

On big endian platform (sparc) I get many of these:

Crash Annotation GraphicsCriticalError: |[0][GFX1]: Unknown image format 1 (t=17.8415) [GFX1]: Unknown image format 1
Crash Annotation GraphicsCriticalError: |[0][GFX1]: Unknown image format 1 (t=17.8415) |[1][GFX1]: Unknown image format 0 (t=17.8607) [GFX1]: Unknown image format 0
..

There seems to be the same issue on PPC:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1562385
(Reporter)

Comment 1

7 months ago
Created attachment 8843900 [details] [diff] [review]
Possible patch

We are using this patch for many months now (it works both on intel and sparc with FF 45ESR releases and now with 52 too).
(Reporter)

Updated

7 months ago
Attachment #8843900 - Flags: review?(jmuizelaar)
Attachment #8843900 - Flags: review?(gw)

Updated

7 months ago
Component: Untriaged → Graphics
Product: Firefox → Core
It looks like this is what we're hitting: http://searchfox.org/mozilla-central/source/gfx/2d/HelpersCairo.h#163

Somewhere we're getting an incoming image format in either BGRA (0) or BGRX (1) instead of ARGB or XRGB which is what we're supposed to get on BE. Are we setting a SurfaceFormat to A8R8G8B8 instead of A8R8G8B8_UINT32 somewhere?
Comment on attachment 8843900 [details] [diff] [review]
Possible patch

Review of attachment 8843900 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, this needs to be fixed properly. Can you get a stack for the crash?
Attachment #8843900 - Flags: review?(jmuizelaar) → review-
(Reporter)

Comment 4

7 months ago
I hope this is the right stack:

firefox:core> $C
dfbfb830 libxul.so`_ZN7mozilla5image13nsIconDecoder15ReadRowOfPixelsEPKcj+0x3c(52d2518, 52cd71a, c0, 2, 53c26a0, 539ee58)
dfbfb8d0
libxul.so`_ZN7mozilla5image14StreamingLexerINS0_13nsIconDecoder5StateELj16EE3LexIZNS2_8DoDecodeERNS0_20SourceBufferIteratorEPNS0_10IResumableEEUlS3_PKcjE_EEN
S_7VariantIJNS0_13TerminalStateENS0_5YieldEEEES7_S9_T_+0x7ec(52d2640, 52d2550, 52cb9e4, 2, dfbfbb28, 0)
dfbfba58 libxul.so`_ZN7mozilla5image13nsIconDecoder8DoDecodeERNS0_20SourceBufferIteratorEPNS0_10IResumableE+0x20(52d2518, 52d2550, 52cb9e4, 0, 5273028,
dfbfbb28)
dfbfbac0 libxul.so`_ZN7mozilla5image7Decoder6DecodeEPNS0_10IResumableE+0xa0(52d2518, 52cb9e4, f0373280, e6d5ca40, dfbfbb28, dfbfbba0)
dfbfbb38 libxul.so`_ZN7mozilla5image22DecodedSurfaceProvider3RunEv+0x60(52cb998, 0, 1, 0, 52cb9e4, 52d2518)
dfbfbbd0 libxul.so`_ZN7mozilla5image16DecodePoolWorker3RunEv+0x368(783d40, 0, dfbfbca8, 8, 52cb9e4, 29218b0)
dfbfbc48 libxul.so`_ZN8nsThread16ProcessNextEventEbPb+0x310(1, 0, dfbfbd37, 0, 0, 29262f0)
dfbfbcd0 libxul.so`_Z19NS_ProcessNextEventP9nsIThreadb+0x30(29262f0, 0, 293c154, dfbfbd20, 134, 0)
dfbfbd38 libxul.so`_ZN7mozilla3ipc28MessagePumpForNonMainThreads3RunEPN4base11MessagePump8DelegateE+0x1d4(2944180, 293c148, f0375ccc, 2944190, 29262f0, 0)
dfbfbda8 libxul.so`_ZN11MessageLoop11RunInternalEv+0x10(293c148, 293c148, dfbfbe58, 2944190, ee43e504, 29264b8)
dfbfbe08 libxul.so`_ZN11MessageLoop3RunEv+0x10(293c148, 29441a8, 0, 0, 2944184, 2944180)
dfbfbe78 libxul.so`_ZN8nsThread10ThreadFuncEPv+0x1d8(29262f0, 293ba90, 293c148, 29262fc, ffffff, 2926324)
dfbfbef8 libnspr4.so`_pt_root+0x10c(293ba90, 0, 0, 1a, 0, efe695f0)
dfbfbf60 libc.so.1`_lwp_start(0, 0, 0, 0, 0, 0)
http://searchfox.org/mozilla-central/source/image/decoders/nsIconDecoder.cpp#74 looks promising
Attachment #8843900 - Flags: review?(gw)
The crash stack should have a call to GfxFormatToCairoFormat
(Reporter)

Comment 7

7 months ago
Created attachment 8845302 [details]
Full Firefox console output ending unrelated crash.
(Reporter)

Comment 8

7 months ago
Is it possible that there is no crash for this issue? Just those errror messages?

Where it finally crash for other unrelated issue? See above attached log for example. 
(This particular unrelataed issue is logged under: https://bugzilla.mozilla.org/show_bug.cgi?id=1345102)

Comment 9

7 months ago
That may be a dupe (or a variant) of Bug 1343511.

Updated

6 months ago
Whiteboard: [gfx-noted]
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.